add Compat middleware #1865
Merged
add Compat middleware #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
approved these changes
Jan 4, 2021
src/middleware/scoped.rs
Outdated
| type Future = ScopedFuture<S::Future>; | ||
|
|
||
| fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> { | ||
| self.service.poll_ready(cx).map_err(From::from) |
There was a problem hiding this comment.
thought: should this be the definition of the new forward_ready! macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Check your PR fulfills the following:
Overview
Added
Compatmiddleware. It would transform any middleware and outputResult<ServiceResponse<Body>, Error>(as long as the transformed output can be convert to it).This enables
CompressandLoggermiddleware being used inConditionmiddleware andResource/Scopeservice.The name of the middleware could be named better and ideas are welcome.
Closes #1448