Use immutable reference of service state. Update awc dns resolver. #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakeshadow
added
A-awc
fakeshadow
changed the title
fakeshadow
force-pushed
the
feat/immutable
branch
from
464d4c0
to
bcc60b0
Compare
robjtede
approved these changes
Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
Check your PR fulfills the following:
Overview
In general
actix-webdoes not need immutable service state.This PR address changes from actix/actix-net#247 and actix/actix-net#248
It would reduce runtime borrow check by 2 for every service call, by 3 for tls service call, by 1 for every layer of middleware service call where call happens after call future polled.