New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WsResponseBuilder
to build web socket session response
#1920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd like to see one test where the frame size is exceeded producing an error
Any update on this PR/when it will land? Seems stale, can fill in and complete any tasks that remain to be done Edit: ping on this, definitively stale at this point, how can I step in to push it along? |
thanks for getting this started @sazid and for everyone else's patience :) |
PR Type
Feature
PR Checklist
Overview
New: You can now start a websocket session with a frame size or a
actix_http::ws::Codec
by using thews:WsResponseBuilder
.Example:
There are two terminal methods for the builder. This is in line with two existing
start()
andstart_with_addr()
fns.start()
which starts the actor and returns a response.start_with_addr()
which starts the actor and returns both the addr of the actor and the response.Fixes #1873