Don't normalize URIs with no valid path #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
approved these changes
Jun 3, 2021
ibraheemdev
reviewed
Jun 3, 2021
ibraheemdev
reviewed
Jun 3, 2021
ibraheemdev
suggested changes
Jun 3, 2021
|
Updated and rebased, but really not sure what is happening in the macOS CI... |
|
Nice job, thanks for taking the time to work though it with me in chat and get this PR together 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
Overview
During path normalization, we were transforming an empty path into
/, which would create an invalid URI in the case where the original URI was in the authority form (no path nor scheme), which in turn would cause a panic because of anunwrap.Closes #2240