Replace askama_escape in favor of v_htmlescape #2402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided on askama_escape in this PR because of it's better compile time, is v_htmlescape any closer to this goal now? The rationale is that this is not called very often at all and as such it is better for consumers of actix-web to have improved compile times when using actix-files. |
|
It is not so much and yes, I can reduce the compilation time a lot, there are many things that were for testing. I will notify you when I make the change. |
|
just doing some clean up, feel free to re-open if things change |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor/Other
PR Checklist
Overview
I have already uncoupled the crates
bytesfromv_escape. This version is several times faster as it is optimized with SIMD instructions.