make AnyBody generic on Body type
#2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
force-pushed
the
anybody-generic
branch
from
3403095
to
0b13d27
Compare
robjtede
added
A-http
robjtede
changed the title
AnyBody generic on Body type
fakeshadow
reviewed
Nov 16, 2021
fakeshadow
reviewed
Nov 16, 2021
fakeshadow
reviewed
Nov 16, 2021
ibraheemdev
reviewed
Nov 16, 2021
| @@ -33,39 +36,70 @@ impl AnyBody { | |||
| Self::Bytes(Bytes::new()) | |||
| } | |||
|
|
|||
| /// Create body from slice (copy) | |||
| /// Create boxed body from generic message body. | |||
| pub fn new_boxed<B>(body: B) -> Self | |||
There was a problem hiding this comment.
Maybe just call this boxed?
There was a problem hiding this comment.
toyed wth the idea yea
the counter argument is that boxed is well known as a combinator-style method in futures-util: https://docs.rs/futures-util/0.3.17/futures_util/future/trait.FutureExt.html#method.boxed
There was a problem hiding this comment.
Im sure counter examples exist. This shouldn't get used too much i think. I just like the idea of being explicit about its function and that new and new_boxed would be together in the docs.rs sidebar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
Overview
Big clean up. Altering
AnyBodyto be generic on the "other" body type and finally removingResponseBody.One more egonomic improvement after this will be a method on HttpResponseBuilder for matching the B parameter and another method for boxing the body. These should greatly reduce the number of map_body calls needed currently when handling polymorphic response bodies.