Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: 304 Not Modified responses omit Content-Length header #2453

Merged
merged 6 commits into from Nov 19, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Nov 18, 2021

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Spec references in the code.
Further work can be done to include support for writing the CL header and omitting the body; currently the tests show that this works if you provide a None body, so it has not been noted in the changelog or used in -files yet.

Supercedes #2353

@robjtede robjtede added the A-files project: actix-files label Nov 18, 2021
@robjtede robjtede marked this pull request as ready for review November 18, 2021 16:41
@robjtede robjtede requested a review from a team November 18, 2021 17:14
@robjtede robjtede merged commit 194a691 into master Nov 19, 2021
@robjtede robjtede deleted the files-not-modified branch November 19, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-files project: actix-files B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant