Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor testing utils #2518

Merged
merged 9 commits into from
Dec 15, 2021
Merged

refactor testing utils #2518

merged 9 commits into from
Dec 15, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Dec 14, 2021 •
edited
Loading

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

  • document main test module
  • rename test util calls and deprecate old names
  • remove unpin bounds from test utils
  • split test module
  • use to_bytes in body reading impls
  • test util body errors only require Debug
  • rename default_service to simple_service
  • remove test load_stream and load_body

@robjtede robjtede added A-web project: actix-web B-semver-minor labels Dec 14, 2021
@robjtede robjtede marked this pull request as ready for review December 14, 2021 23:52
@robjtede robjtede changed the title Testing-utils refactor testing utils Dec 14, 2021
@robjtede robjtede added this to the actix-web v4 milestone Dec 14, 2021
@robjtede robjtede added B-semver-major breaking change requiring a major version bump and removed B-semver-minor labels Dec 15, 2021
@robjtede robjtede merged commit 156cc20 into master Dec 15, 2021
@robjtede robjtede deleted the testing-utils branch December 15, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-web project: actix-web B-semver-major breaking change requiring a major version bump
Projects
None yet
Milestone
actix-web v4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robjtede