Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
Overview
The
BodyEncoding
trait is largely unnecessary.This changes encoding signalling to only use the
Content-Encoding
header which was necessary to use anyway to stay spec compliant. TheCompress
middleware already skips encoding for any responses with this header so the sole function of this trait was to force an encoding.Therefore, the only specific function this trait had was to force an encoding on a per-response basis; I consider this too niche a use case to support.