Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix request head timeout #2611

Merged
merged 29 commits into from
Jan 31, 2022
Merged

fix request head timeout #2611

merged 29 commits into from
Jan 31, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Jan 27, 2022

PR Type

Fix and Docs

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

TODO:

  • perf testing
  • unboxing can come later given the perf testing

closes #1269

@robjtede robjtede changed the title rename parts of ServiceConfig fix request head timeout Jan 28, 2022
@robjtede robjtede added A-http project: actix-http B-semver-patch B-semver-major breaking change requiring a major version bump and removed B-semver-patch labels Jan 29, 2022
@robjtede robjtede added this to the actix-web v4 milestone Jan 29, 2022
@robjtede
Copy link
Member Author

robjtede commented Jan 29, 2022

not seeing any big difference in perf:

# before
 › vegeta attack -targets=target.list -duration=40s -rate=100/s | tee results.bin | vegeta report
Requests      [total, rate, throughput]         4000, 100.02, 100.02
Duration      [total, attack, wait]             39.99s, 39.99s, 237.958µs
Latencies     [min, mean, 50, 90, 95, 99, max]  71.75µs, 700.113µs, 539.2µs, 1.137ms, 1.681ms, 4.469ms, 10.014ms
Bytes In      [total, mean]                     7432000, 1858.00
Bytes Out     [total, mean]                     0, 0.00
Success       [ratio]                           100.00%
Status Codes  [code:count]                      200:4000
Error Set:

# after
 › vegeta attack -targets=target.list -duration=40s -rate=100/s | tee results.bin | vegeta report
Requests      [total, rate, throughput]         4000, 100.02, 100.02
Duration      [total, attack, wait]             39.991s, 39.99s, 338.791µs
Latencies     [min, mean, 50, 90, 95, 99, max]  87µs, 689.905µs, 521.139µs, 1.174ms, 1.731ms, 4.375ms, 10.126ms
Bytes In      [total, mean]                     7432000, 1858.00
Bytes Out     [total, mean]                     0, 0.00
Success       [ratio]                           100.00%
Status Codes  [code:count]                      200:4000
Error Set:

@robjtede robjtede marked this pull request as ready for review January 29, 2022 21:19
@robjtede robjtede merged commit 3200de3 into master Jan 31, 2022
@robjtede robjtede deleted the request-timeout branch January 31, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http B-semver-major breaking change requiring a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client timeout starts too early causing "408" errors
1 participant