Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC refinements #2625

Merged
merged 5 commits into from
Feb 4, 2022
Merged

RC refinements #2625

merged 5 commits into from
Feb 4, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Feb 4, 2022 •
edited
Loading

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Stuff I've noticed while migrating our TFB code.

@robjtede robjtede changed the title implement responder for byte vec rc refinements Feb 4, 2022
@robjtede robjtede added A-http project: actix-http A-web project: actix-web B-semver-minor labels Feb 4, 2022
@robjtede robjtede added this to the actix-web v4 milestone Feb 4, 2022
@robjtede robjtede changed the title rc refinements RC refinements Feb 4, 2022
@robjtede robjtede marked this pull request as ready for review February 4, 2022 19:46
@robjtede
Copy link
Member Author

robjtede commented Feb 4, 2022

Actually write_date_header (previously set_date) was doc(hidden) in v3. It's used in TFB code though. Should we keep it hidden? What do you think @aliemjay?

@aliemjay
Copy link
Member

aliemjay commented Feb 4, 2022

I've never been involved in this area before, but from a quick glance I see it like an alien api for ServiceConfig is being exposed. Making it doc(hidden) maybe better given it would make it exempt from our semver guarantees. Still not sure though!

@robjtede
Copy link
Member Author

robjtede commented Feb 4, 2022 •
edited
Loading

alien api for ServiceConfig

Yeah glad you brought that up, fresh pair of eyes are valuable. I agree; gonna hide it again.

@robjtede robjtede merged commit 1d1a652 into master Feb 4, 2022
@robjtede robjtede deleted the refinements branch February 4, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-http project: actix-http A-web project: actix-web B-semver-minor
Projects
None yet
Milestone
actix-web v4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robjtede @aliemjay