Add ability to set default error handlers to the ErrorHandler middleware
#2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
reviewed
Jun 23, 2022
| @@ -53,7 +55,38 @@ type ErrorHandler<B> = dyn Fn(ServiceResponse<B>) -> Result<ErrorHandlerResponse | |||
| /// .wrap(ErrorHandlers::new().handler(StatusCode::INTERNAL_SERVER_ERROR, add_error_header)) | |||
| /// .service(web::resource("/").route(web::get().to(HttpResponse::InternalServerError))); | |||
| /// ``` | |||
| /// ## Registering default handler | |||
There was a problem hiding this comment.
Explain the precedence of overlapping handlers.
There was a problem hiding this comment.
hope the new docs are clearer. lmk if anything still doesn't make sense!
… into default_error_handler
popzxc
approved these changes
Jun 27, 2022
|
Check failed due to rust-lang/rust#99261 which looks to have been fixed on latest nightly |
robjtede
approved these changes
Sep 15, 2022
|
Thanks for the contribution 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
Currently, each error handler has to be set separately for each status code. It's cumbersome to have to add a line for each status code, and ripe for errors if some codes are missed.
This PR allows the user to set a default handler either for all errors, or separate defaults for client and server errors, while still allowing other handlers to be tied to specific status codes. It defines the following new methods on
middleware::ErrorHandlers:default_handler: sets a default handler that will be used if the given status code doesn't have another handler specifieddefault_handler_client: sets a default handler only for client errors (400-499)default_handler_server: sets a default handler only for server errors (500-599)This PR contains no breaking changes; other than the additions above, the only changes are to private fields/types.
Closes #2667.