Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use noop hasher in extensions #2890

Merged
merged 1 commit into from Sep 25, 2022
Merged

use noop hasher in extensions #2890

merged 1 commit into from Sep 25, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Sep 24, 2022 •
edited

PR Type

Perf

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Idea is that TypeId are already hash-random so a hasher is not necessary here.

closes #2850

@robjtede robjtede added A-http project: actix-http B-semver-norelease change that does not require a release labels Sep 25, 2022
@robjtede robjtede marked this pull request as ready for review September 25, 2022 13:19
@robjtede robjtede merged commit 172c4c7 into master Sep 25, 2022
@robjtede robjtede deleted the noop-hasher branch September 25, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-http project: actix-http B-semver-norelease change that does not require a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use no-op hasher in Extensions
1 participant
@robjtede