Add fallible versions of test_utils helpers to actix-test #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
Jan 9, 2023
Zacho2
commented
Jan 9, 2023
Zacho2
force-pushed
the
fallibile_test_utils
branch
from
e068521
to
c20381a
Compare
|
Seems like the Windows stable/1.59 checks are failing at the step to install OpenSSL. Not sure if that's a known issue or how to resolve it, yet. |
|
It's a new issue but clearly not related to your PR. No worries about that. |
popzxc
approved these changes
Jan 11, 2023
robjtede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
Add fallible versions of
test_utilshelpers for calling test services and reading response payloads. Existing non-fallible call into their fallible counterparts and useunwrap.Resolves #2952