Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap attribute codegen regression when using expression #3119

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix: wrap attribute codegen regression when using expression #3119

merged 2 commits into from
Aug 29, 2023

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Aug 29, 2023 •
edited
Loading

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Fixes #3118

@robjtede robjtede added A-codegen project: actix-web-codegen B-semver-patch labels Aug 29, 2023
@robjtede
Copy link
Member Author

robjtede commented Aug 29, 2023 •
edited
Loading

This must have been one of the bugs with syn v1, it was previously allowing these basic expressions to be parsed as types.

@robjtede robjtede merged commit 76f6106 into master Aug 29, 2023
@robjtede robjtede deleted the fix-syn2-regression branch August 29, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-codegen project: actix-web-codegen B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile errors after actix-web-codegen v4.2.0 -> v4.2.1
1 participant
@robjtede