Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compression middleware prefer brotli over zstd over gzip #3189

Merged
merged 6 commits into from
Nov 19, 2023
Merged

Make compression middleware prefer brotli over zstd over gzip #3189

merged 6 commits into from
Nov 19, 2023

Conversation

amitu
Copy link
Contributor

@amitu amitu commented Nov 15, 2023 •
edited by robjtede
Loading

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Closes #3187.

amitu
amitu commented Nov 15, 2023
View reviewed changes
actix-web/tests/compression.rs Outdated Show resolved Hide resolved
@robjtede robjtede added B-semver-patch A-web project: actix-web labels Nov 15, 2023
robjtede
robjtede approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍🏻 😄

@robjtede robjtede added this pull request to the merge queue Nov 19, 2023
Merged via the queue into actix:master with commit c0615f2 Nov 19, 2023
12 checks passed
@amitu amitu deleted the encoding_ranking branch November 20, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.negotiate() prefers gzip over brotli
2 participants
@amitu @robjtede