Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require actix-router default features from actix-web-codegen #3372

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

dbanty
Copy link
Contributor

@dbanty dbanty commented May 19, 2024

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

This should allow you to omit the regex dependency when using actix-web 4.6.0 with the macros feature enabled (and no unicode).

@robjtede robjtede added A-codegen project: actix-web-codegen B-semver-patch labels Jun 7, 2024
@robjtede robjtede enabled auto-merge June 7, 2024 13:22
@robjtede
Copy link
Member

robjtede commented Jun 7, 2024

Turns out we actually have a concession here in that the errors are strictly worse with the unicode feature disables. Only those who explicitly disable it will see them though, so I'm okay with it.

 13 | #[get("/{}")]
    | ^^^^^^^^^^^^^
    |
-   = help: message: Wrong path pattern: "/{}" regex parse error:
-               ((?s-m)^/(?P<>[^/]+))$
-                            ^
-           error: empty capture group name
+   = help: message: Wrong path pattern: "/{}" empty capture group names are not allowed

@robjtede robjtede added this pull request to the merge queue Jun 7, 2024
Merged via the queue into actix:master with commit b2d0196 Jun 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen project: actix-web-codegen B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants