Improve StaticFiles performance, and make ChunkedReadFile public #571
Conversation
| @@ -88,7 +88,8 @@ where | |||
| Ok(Async::Ready(())) | |||
| } | |||
|
|
|||
| fn call(&mut self, req: Self::Request) -> Self::Future { | |||
| fn call(&mut self, mut req: Self::Request) -> Self::Future { | |||
| let _ = req.set_nodelay(true); | |||
There was a problem hiding this comment.
There is separate service for that
There was a problem hiding this comment.
You mean StreamConfigurationService?
There was a problem hiding this comment.
Well, this is the simplest solution I found to the issue. If you want to solve the issue in a different way, I could modify the pull request.
| file: Option<File>, | ||
| fut: Option<CpuFuture<(File, Bytes), io::Error>>, | ||
| counter: u64, | ||
| pub size: u64, |
There was a problem hiding this comment.
What is the reason for this change?
There was a problem hiding this comment.
ChunkedReadFile is public and shows up in the documentation, but it isn't useable in handlers, because its fields are private.
There was a problem hiding this comment.
So, are you okay with this change being included in the pull request?
It makes sense for ChunkedReadFile's fields to be public, as it's not useable when the fields are private. Why have ChunkedReadFile show up in the docs if you don't want people to use it?
|
i dont think it make sense to expose |
This fixes issue #560, and also addresses some concerns brought up about ChunkedReadFile.
Sorry about the weird commit names, I was using my phone to do this.