Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: sequence in query and form extractors do not work #664

Closed
wants to merge 1 commit into from

Conversation

AnderEnder
Copy link
Contributor

Common multiple params usage in query and form can not be used with actix-web:

  • example url: /index.html?first_name=John&last_name=Doe&emails=john%40example.com&emails=doe%40example.com
  • example form body: first_name=John&last_name=Doe&emails=john%40example.com&emails=doe%40example.com

These are two test cases to represent the issue.

@DoumanAsh
Copy link
Contributor

There is not much meaning with test case alone, but if I remember correctly we use serde_urlencoded to extract from query, so the functionality can be only added there

@AnderEnder
Copy link
Contributor Author

Sure, these test case only represents the issues, the behaviour which is required, but not provided by actix-web. My expectation that web framework should support it. Currently I can not implement simple API and this stops the development.

AFAIK, serde_urlencoded does not want to support anything more, so the question to actix-web how to support it.

The issue is quite similar to #371, so the private serde_urlencoded was created as result.

@DoumanAsh
Copy link
Contributor

AFAIK, serde_urlencoded does not want to support anything more, so the question to actix-web how to support it.

the author of library did accept PR and we removed private fork. I think first step would be for us to write PR that implements this feature

@AnderEnder
Copy link
Contributor Author

AnderEnder commented Jan 16, 2019

The author did not accept required feature. Related PR: nox/serde_urlencoded#42

@fafhrd91
Copy link
Member

We could switch to different library.

@AnderEnder you should understand, this is open source software and maintainers may not have free time to implement every feature. PR is always welcomed

@AnderEnder
Copy link
Contributor Author

@fafhrd91, there is no similar library. And this is a common case(not feature) when a form submit multiple values.

@DoumanAsh and @fafhrd91
What do you suggest? Create a private fork here?

@DoumanAsh
Copy link
Contributor

@AnderEnder There is serde_qs that was created to address this limitation it seems

@fafhrd91 fafhrd91 closed this Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants