Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Factory and AsyncFactory and some clippy fixes #983

Merged
merged 1 commit into from Jul 17, 2019

Conversation

wafflespeanut
Copy link
Contributor

Paperclip is an OpenAPI tooling library. The first of its upcoming server-side features is to support hosting a specification based on models and registered functions. More context in #310 (comment).

Since the plugin relies on wrapping a number of Actix objects, it needs the internal Factory and AsyncFactory traits so that we can place appropriate bounds. This PR exposes them through dev module and fixes some (future) clippy errors.

@wafflespeanut
Copy link
Contributor Author

cc @fafhrd91

@fafhrd91
Copy link
Member

let's split this pr into multiples. one for exposing factory traits and other for cosmetic changes

@fafhrd91
Copy link
Member

Actually, let me just merge. I’d like to make new release

@wafflespeanut
Copy link
Contributor Author

Ok thank you 😄

@fafhrd91 fafhrd91 merged commit 32718b7 into actix:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants