Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change return value to Result for SinkWriter::write #499

Merged
merged 2 commits into from
May 28, 2021
Merged

Change return value to Result for SinkWriter::write #499

merged 2 commits into from
May 28, 2021

Conversation

danielalvsaaker
Copy link
Contributor

@danielalvsaaker danielalvsaaker commented May 18, 2021 •
edited by robjtede
Loading

PR Type

Refactor

PR Checklist

Check your PR fulfills the following:

  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Resolves the changes discussed in #498. SinkWriter::write should return a Result instead of an Option.

Closes #498.

@danielalvsaaker danielalvsaaker marked this pull request as ready for review May 18, 2021 15:02
@danielalvsaaker danielalvsaaker changed the title SinkWrite::write returns Result instead of Option Change return value to Result for SinkWriter::write May 18, 2021
@robjtede robjtede merged commit 0837304 into actix:master May 28, 2021
robjtede pushed a commit to Michael-F-Bryan/actix that referenced this pull request Jul 24, 2023
@danielalvsaaker @robjtede
Change return value to Result for SinkWriter::write (actix#499)
8e961b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SinkWrite::write should return Result<(), I> instead of Option<I>
2 participants
@danielalvsaaker @robjtede