-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide full configuration of underlying Shepherd.Tour JS component #8
Comments
Great question. Is there a way we could do both, i.e. a YAML-driven approach for the simple cases, and a PORO-driven approach for full customization? My primary motivation for creating Abraham was to simplify the implementation of the most typical product tours, after building them by hand with the same Shepherd configuration each and every time. This way, it becomes possible for non-developer team members to compose and refine tour flow/content. Whatever we do, I want to ensure we maintain that possibility. |
I understand the need and think it's great, but I also think it's a great gem for more technical profiles. Convention by default, configuration if needed :) How could we configure yml vs ruby without checking at each controller call ? |
@kofronpi FYI, in addressing #22, I'm going to make Putting JSON into YAML isn't the most beautiful thing to do, but it'll get the job done ;) For example: defaults: &defaults
:tour_options: '{ classPrefix: "abraham-" }' |
Right now, the shepherd component is initialized like this:
It would be great to be able to use all of Shepherd.js options.
Maybe it would be easier to do with PORO Abrahamah tours rather than yml files, just suggesting :)
The text was updated successfully, but these errors were encountered: