Add arg for worker threads & fix stats init #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have a configurable number of worker threads although we still default to the number of detects CPU cores (logical cores a.k.a. threads really). This makes it possible to just play around with what happens with lower count or whatever. The fixed number of max worker threads (32) was rather low. It's bumped up to 256, now using a single define MAX_WTHREADS so it is consistent and easy to change. There is also a check that we don't actually try to run with a higher number. Alternatively I guess we could malloc this structure but I dunno... this just felt simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a configurable number of worker threads although we still
default to the number of detects CPU cores (logical cores a.k.a. threads
really). This makes it possible to just play around with what happens
with lower count or whatever.
The fixed number of max worker threads (32) was rather low. It's bumped
up to 256, now using a single define MAX_WTHREADS so it is consistent
and easy to change. There is also a check that we don't actually try to
run with a higher number.
Alternatively I guess we could malloc this structure but I dunno... this
just felt simple.