Do not use uuid from util-linux on MacOS #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that we might have been compiling with a uuid.h from the MacOS base / SDK but linked with uuid from util-linu and this might be the cause of certain segfaults. Looks like we don't need -luuid on Mac, it works anyway, so trying to align so we get the same version of headers and library by ditching use of util-linux libuuid on Mac. We still use it on Linux!
It's not needed anymore, we use the native uuid lib on MacOS.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that we might have been compiling with a uuid.h from the
MacOS base / SDK but linked with uuid from util-linu and this might be
the cause of certain segfaults.
Looks like we don't need -luuid on Mac, it works anyway, so trying to
align so we get the same version of headers and library by ditching use
of util-linux libuuid on Mac. We still use it on Linux!
Fixes #487.