Revamp remaining RTS DB tests #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the two remaining RTS DB test; the simple test app and the TCP client resume test in the style of the TCP server test, which I previously rewrote to use a new test orchestrator (written in Acton). Pretty messy code, though it works and the tests execute very fast and print most relevant debug information if anything goes wrong. I'm able to run many test iterations without problems!
Include the state when printing app output.
plajjan
force-pushed
the
revamp-db-tests
branch
from
4a560fc
to
012e564
Compare
|
I'm a little stumped. After merging the first revamped test for the TCP server, I have had several failed PR test rounds where the test times out. I've run thousands of iterations on my machine which have worked just fine. There are some segfaults but they are rare (<1% which is less than what we had before)... in this PR I've added some better log output but also extended the timeout. Are the test machines so damn slow? A test run completes in <0.4 seconds on my machine and the timeout was 2 seconds. It's now 5 seconds... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the two remaining RTS DB test; the simple test app and the TCP client resume test in the style of the TCP server test, which I previously rewrote to use a new test orchestrator (written in Acton).
Pretty messy code, though it works and the tests execute very fast and print most relevant debug information if anything goes wrong.
I'm able to run many test iterations without problems!