Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete experimental features #1764

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

Neverlord
Copy link
Member

Profiling and tracing are both interesting features to have, but they do overlap with metrics (at least the profiling) and were never fully fleshed out. I think we'll revisit both ideas at some point in the future, but the current implementations are too bare-bone.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab1f6bf) 71.11% compared to head (e7d6ea9) 71.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
+ Coverage   71.11%   71.20%   +0.08%     
==========================================
  Files         644      641       -3     
  Lines       27429    27379      -50     
  Branches     3009     3006       -3     
==========================================
- Hits        19506    19494      -12     
+ Misses       6209     6168      -41     
- Partials     1714     1717       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@riemass riemass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick grep and the profiler is mentioned in actor_system_config.cpp and the configure script. Otherwise, looks good.

@Neverlord
Copy link
Member Author

I did a quick grep and the profiler is mentioned in actor_system_config.cpp and the configure script. Otherwise, looks good.

Good catch, thanks for double checking!

@Neverlord Neverlord merged commit 190ccd0 into master Feb 21, 2024
10 checks passed
@Neverlord Neverlord deleted the topic/neverlord/cleanup branch February 21, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants