Achieve complete type safe of typed_broker

[ufownl]

Relates #309 .

We can just enforcing all message handlers on the typed actors that they are used as server.

[Inet-Jenkins]

Can one of the admins verify this patch?

[ufownl]

I tried to use std::is_convertible but it didn't work.

[Neverlord]

It does, my example code was a bit incorrect. It used to be handle::extend<...>::type, which is a bit verbose for my taste anyway. I changed it to accept handle::extend<...> instead [1] and also verified that std::is_convertible works as expected in the typed_spawn unit tests.

So the preferred syntax should work for you after a rebase.

[1] 0dc6005

[ufownl]

It does, my example code was a bit incorrect. It used to be handle::extend<...>::type, which is a bit verbose for my taste anyway.

I don't mean that.

// check invariants of type system
using dummy1 = typed_actor<reacts_to<int, int>,
                           replies_to<double>::with<double>>;

//using dummy2 = dummy1::extend<reacts_to<ok_atom>>;
using dummy2 = typed_actor<reacts_to<ok_atom>>;

static_assert(std::is_convertible<dummy2, dummy1>::value,
              "handle not assignable to narrower definition");

It has no compilation error on my computer, does it work as expected?

[Neverlord]

It has no compilation error on my computer, does it work as expected?

Crap. The handles are always assignable and only check via static_assert if the assignment is correct. I'm working on a fix.

[Neverlord]

I'm really sorry for not double-checking this prior to pushing the code to GitHub. I've added a counter-test to the unit test and use SFINAE to make assigning invalid handles impossible: b6a1811

Thank you for your patience (and double-checking the nonsense I wrote). :)

[ufownl]

Now, it works fine! And the newest commit has been pushed. :)

[Neverlord]

@Inet-Jenkins ok to test

[ufownl]

Jenkins didn't work, what's wrong with it?

[Neverlord]

Sometimes Jenkins picks up the wrong hash for some reason.

@Inet-Jenkins retest this please

[ufownl]

Seems Jenkins hates this PR.

[Neverlord]

Looks like it..