Fix disconnect issue on Windows #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WSAGetLastError should be invoked right after Windows sockets functions.
Neverlord
requested changes
May 31, 2019
libcaf_io/src/tcp.cpp
Outdated
| CAF_LOG_DEBUG(CAF_ARG(len) << CAF_ARG(fd) << CAF_ARG(sres)); | ||
| if (is_error(sres, true)) | ||
| if (is_error(sres, true)) { | ||
| CAF_LOG_ERROR("send failed:" << last_socket_error_as_string()); |
|
@v2nero would you mind double-checking whether this PR fixes the issues you've reported? |
simple_broker works with CAF_LOG_LEVEL=TRACE with your changes. This is the only case I tested before. |
|
Thanks for taking the time and testing the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WSAGetLastError should be invoked right after Windows sockets functions. Addresses the issue raised in #837.