refactor: Improve Python import helpers (#1316)

after my recent changes hepmc3 test will only run if the environment is sourced. this refactors the import helpers in order to fix that

Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/EDM4hepSimHitReader.hpp

@@ -71,6 +71,8 @@ class EDM4hepSimHitReader final : public IReader {
   std::vector<std::string> m_collections;
 
   const edm4hep::MCParticleCollection* m_mcParticleCollection;
+
+  const Acts::Logger& logger() const { return *m_logger; }
 };
 
 }  // namespace ActsExamples

Examples/Io/EDM4hep/src/EDM4hepSimHitReader.cpp

@@ -96,8 +96,7 @@ ProcessCode EDM4hepSimHitReader::read(const AlgorithmContext& ctx) {
               });
           unordered.push_back(std::move(hit));
         } catch (...) {
-          m_logger->log(Acts::Logging::Level::ERROR,
-                        "EDM4hepSimHitReader: failed to convert SimTrackerHit");
+          ACTS_ERROR("EDM4hepSimHitReader: failed to convert SimTrackerHit");
           continue;
         }
       }

Examples/Python/python/acts/examples/edm4hep.py

@@ -1,6 +1,9 @@
 from acts._adapter import _patch_config
 from acts import ActsPythonBindings
 
+if not hasattr(ActsPythonBindings._examples, "_edm4hep"):
+    raise ImportError("ActsPythonBindings._examples._edm4hep not found")
+
 _patch_config(ActsPythonBindings._examples._edm4hep)
 
 from acts.ActsPythonBindings._examples._edm4hep import *

Examples/Python/python/acts/examples/hepmc3.py

@@ -1,6 +1,9 @@
 from acts._adapter import _patch_config
 from acts import ActsPythonBindings
 
+if not hasattr(ActsPythonBindings._examples, "_hepmc3"):
+    raise ImportError("ActsPythonBindings._examples._hepmc3 not found")
+
 _patch_config(ActsPythonBindings._examples._hepmc3)
 
 from acts.ActsPythonBindings._examples._hepmc3 import *

Examples/Python/tests/helpers/__init__.py

@@ -33,19 +33,19 @@
     except ImportError:
         dd4hepEnabled = False
 
-hepmc3Enabled = "HepMC3_DIR" in os.environ
-if hepmc3Enabled:
-    try:
-        import acts.examples.hepmc3
-    except ImportError:
-        hepmc3Enabled = False
+try:
+    import acts.examples.hepmc3
 
-edm4hepEnabled = "EDM4HEP_DIR" in os.environ
-if edm4hepEnabled:
-    try:
-        import acts.examples.edm4hep
-    except ImportError:
-        edm4hepEnabled = False
+    hepmc3Enabled = True
+except ImportError:
+    hepmc3Enabled = False
+
+try:
+    import acts.examples.edm4hep
+
+    edm4hepEnabled = True
+except ImportError:
+    edm4hepEnabled = False
 
 isCI = os.environ.get("CI", "false") == "true"
 

Examples/Python/tests/test_reader.py

@@ -340,7 +340,7 @@ def test_edm4hep_simhit_reader(tmp_path):
 
     assert os.path.exists(tmp_file)
 
-    detector, _, _ = getOpenDataDetector()
+    detector, trackingGeometry, decorators = getOpenDataDetector()
 
     s = Sequencer(numThreads=1)