ci: Physmon follow up: enable failure again (#1237)

Based on #1222 With #1222 in, we can have the python level tests and the perf monitoring fail independently of one another. This PR enables that again. Also bumps `histcmp` to v0.4.0 for a fix for missing legends in some plots, and to include standalone PDFs in addition to the HTML report.
acts-project · May 5, 2022 · 0b8796e · 0b8796e
1 parent 3b64bad
commit 0b8796e
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml
@@ -209,7 +209,7 @@ jobs:
         run: >
           echo "::group::Dependencies"
           && git config --global safe.directory "$GITHUB_WORKSPACE"
-          && pip3 install histcmp==0.3.1
+          && pip3 install histcmp==0.4.0
           && /usr/local/bin/download_geant4_data.sh
           && source /usr/local/bin/thisroot.sh
           && source /usr/local/bin/thisdd4hep_only.sh

diff --git a/CI/physmon/phys_perf_mon.sh b/CI/physmon/phys_perf_mon.sh
@@ -27,7 +27,7 @@ function run() {
     histcmp \
         --label-reference=$refcommit \
         --label-monitored=$commit \
-        "$@" || true
+        "$@"
 
     ec=$(($ec | $?))
 
@@ -41,25 +41,29 @@ run \
     --title "CKF truth smeared" \
     -c CI/physmon/ckf_truth_smeared.yml \
     -o $outdir/ckf_truth_smeared.html \
+    -p $outdir/ckf_truth_smeared_plots \
 
 run \
     $outdir/performance_ckf_tracks_truth_estimated.root \
     $refdir/performance_ckf_tracks_truth_estimated.root \
     --title "CKF truth estimated" \
     -o $outdir/ckf_truth_estimated.html \
+    -p $outdir/ckf_truth_estimated_plots \
 
 run \
     $outdir/performance_ckf_tracks_seeded.root \
     $refdir/performance_ckf_tracks_seeded.root \
     --title "CKF seeded" \
     -o $outdir/ckf_seeded.html \
+    -p $outdir/ckf_seeded_plots \
 
 run \
     $outdir/performance_truth_tracking.root \
     $refdir/performance_truth_tracking.root \
     --title "Truth tracking" \
     -c CI/physmon/truth_tracking.yml \
     -o $outdir/truth_tracking.html \
+    -p $outdir/truth_tracking_plots \
 
 
 

diff --git a/CI/physmon/reference/commit b/CI/physmon/reference/commit
@@ -1 +1 @@
-45c23efea
+53187e47b
diff --git a/CI/physmon/reference/performance_ckf_tracks_seeded.root b/CI/physmon/reference/performance_ckf_tracks_seeded.root
diff --git a/CI/physmon/reference/performance_ckf_tracks_truth_estimated.root b/CI/physmon/reference/performance_ckf_tracks_truth_estimated.root
diff --git a/CI/physmon/reference/performance_ckf_tracks_truth_smeared.root b/CI/physmon/reference/performance_ckf_tracks_truth_smeared.root
diff --git a/CI/physmon/reference/performance_truth_tracking.root b/CI/physmon/reference/performance_truth_tracking.root