fix: Generic Detector negative strip endcap rotation (#2358)

Sensors were flipped along local z, meaning they are the wrong way around.

Examples/Detectors/GenericDetector/include/ActsExamples/GenericDetector/ProtoLayerCreatorT.hpp

@@ -486,7 +486,8 @@ ProtoLayerCreatorT<detector_element_t>::createProtoLayers(
           // the module transform from the position
           double modulePhi = phi(ringModulePosition);
           // the center position of the modules
-          Acts::Vector3 moduleCenter(side * ringModulePosition);
+          Acts::Vector3 moduleCenter(ringModulePosition);
+          moduleCenter.z() *= side;
           // the rotation matrix of the module
           Acts::Vector3 moduleLocalY(cos(modulePhi), sin(modulePhi), 0.);
           // take different axis to have the same readout direction

Examples/Python/tests/root_file_hashes.txt

@@ -1,62 +1,62 @@
 test_pythia8__pythia8_particles.root: d9a3d4f16c01aab9984e0e848292760d44015f210878866cc94f3bb9d030034b
-test_fatras__particles_final.root: 59b9f069c0133284070e5c8c313b52d84cd8fdeda49b57d64c8ae2af4fe3e087
+test_fatras__particles_final.root: d3a900a7151623109f2e22e11beb477635eb549d5e611c5fb330a59b41054f59
 test_fatras__particles_initial.root: 0e2d9974fdd4aa5549c5c05817ec54fe6c7d9cbe7969647f227956167e31110d
-test_fatras__hits.root: bda74a44bb9485e62f79d119637ce6c3f38f65491fbee9d43b1ed5bf0cae080c
+test_fatras__hits.root: d3ec06cd12e3737b5c783302ca29a532c885dc35930901d86b2f6d17041037c6
 test_geant4__particles_final.root: abf91622e96c0723651e864e050c7fdeee84b230aacb1c261ad81ff4e5df5f2c
 test_geant4__particles_initial.root: 5be86aa4a2fc369093746451f37085e2c93f80f079b66023f5fe4b67e20100f6
 test_geant4__hits.root: 70b592a546fd362c9341d87c9068b1f8fed657e0036e62e7262c01fa5eb2d469
-test_seeding__estimatedparams.root: 4f8e382817f0634c40293dabc21eefa746fb90eb74f11abe66a2048f5ccfdf2c
+test_seeding__estimatedparams.root: f11b6bdc2b9b13e84f974f2dfbd9f409255f4f0eab212fe8581c352b3f2cfc27
 test_seeding__performance_seeding.root: 992f9c611d30dde0d3f3ab676bab19ada61ab6a4442828e27b65ec5e5b7a2880
 test_seeding__particles.root: 74e08ee12bdaf9f7d273369c71c742df345475c8b73bb7ce223619d0dd1f87ee
-test_seeding__particles_final.root: 13da6831bb08b063a1b417b4f9592e080ad3399ce508fa8876a7c3d1014b3534
+test_seeding__particles_final.root: 3f3eeaedeac050e3dfc5fef37734b0876f4470810e93b371e5da2cb0b987bebd
 test_seeding__particles_initial.root: 74e08ee12bdaf9f7d273369c71c742df345475c8b73bb7ce223619d0dd1f87ee
-test_seeding_orthogonal__estimatedparams.root: da9fc81907de1ca0ef5cbe06ecfbd30cb014513fd28e1b2a8e68fc0856492ac4
+test_seeding_orthogonal__estimatedparams.root: 68cece5ac084cfe12a7fd7ad602ce736edb74ec8f45e0d0468923cd90ec4f95b
 test_seeding_orthogonal__performance_seeding.root: 60fbedcf5cb2b37cd8e526251940564432890d3a159d231ed819e915a904682c
 test_seeding_orthogonal__particles.root: 74e08ee12bdaf9f7d273369c71c742df345475c8b73bb7ce223619d0dd1f87ee
-test_seeding_orthogonal__particles_final.root: 13da6831bb08b063a1b417b4f9592e080ad3399ce508fa8876a7c3d1014b3534
+test_seeding_orthogonal__particles_final.root: 3f3eeaedeac050e3dfc5fef37734b0876f4470810e93b371e5da2cb0b987bebd
 test_seeding_orthogonal__particles_initial.root: 74e08ee12bdaf9f7d273369c71c742df345475c8b73bb7ce223619d0dd1f87ee
-test_itk_seeding__estimatedparams.root: b42e2795c9529735b8b8fdf960b6ed7257c307e0690033b00942377ee6ba4421
+test_itk_seeding__estimatedparams.root: c3ac3c9894b487def066c262ce5aeae3508a0b5a68533f23b5996f2f86f3919b
 test_itk_seeding__performance_seeding.root: 78ebda54cd0f026ba4b7f316724ffd946de56a932735914baf1b7bba9505c29d
 test_itk_seeding__particles.root: 88315e93ed4cb5d40a8721502048a9d1fc100e0a7d504e25fd4502c8302f1578
-test_itk_seeding__particles_final.root: c5cc218b5802fa0829feb2abb113b1eba7f6a4284230fdd9f7c39701da6efd17
+test_itk_seeding__particles_final.root: 0d38f1a4ede5fb86844c156c002ada340011e140a13dacffc1b3848f8bf34dfa
 test_itk_seeding__particles_initial.root: 88315e93ed4cb5d40a8721502048a9d1fc100e0a7d504e25fd4502c8302f1578
 test_propagation__propagation_steps.root: 174301b25784dbb881196b658f2d7f99c0a2ea688a0129e6110fc19aa5cf8e54
 test_material_recording__geant4_material_tracks.root: e411152d370775463c22b19a351dfc7bfe40b51985e10a7c1a010aebde80715d
-test_truth_tracking_kalman[generic-0.0]__trackstates_fitter.root: c37b844dfb86391cc8b8df2a36c1d5de7d37489c0296abcd91ee559c9421933e
-test_truth_tracking_kalman[generic-0.0]__tracksummary_fitter.root: 6c69a3bd0148ed83e761884e630d29ec438772e0fea9ae1ea80e080457c0a8c2
-test_truth_tracking_kalman[generic-0.0]__performance_track_finder.root: 7fc6f717723c9eddcbf44820b384b373cee6f04b72f79902f938f35e3ff9b470
-test_truth_tracking_kalman[generic-1000.0]__trackstates_fitter.root: cee6456f433e00160e47763792a81f90dc264836f7f3cbc3f3aec7528e3cd7fe
-test_truth_tracking_kalman[generic-1000.0]__tracksummary_fitter.root: 1a60281f84e8baaa7e75fb1c842116da81fae0f9273a9a62eeb2cabe26fdf4f6
-test_truth_tracking_kalman[generic-1000.0]__performance_track_finder.root: 7fc6f717723c9eddcbf44820b384b373cee6f04b72f79902f938f35e3ff9b470
+test_truth_tracking_kalman[generic-0.0]__trackstates_fitter.root: c24e50c21efbf37710d038a1015c3a21d3153ded2b5e6c22097442d3aed22209
+test_truth_tracking_kalman[generic-0.0]__tracksummary_fitter.root: 693ee2bb35f3df38b23860c45164f3b7a4b6d6c03b9fcf9a481b7f78d6ff6a39
+test_truth_tracking_kalman[generic-0.0]__performance_track_finder.root: ada9cda2ec3c648b144bdaa081d6eff923c80f3d484c4196006e847428cf67a8
+test_truth_tracking_kalman[generic-1000.0]__trackstates_fitter.root: 07bdf190520e647406b236f3a0d6e1b39e7c553e6ac8e26e16ca34fd1a70e072
+test_truth_tracking_kalman[generic-1000.0]__tracksummary_fitter.root: ad9e386f944e42c04b33eb6aa6ffb4b16719231e6d41375af7049e7ac8c62ed0
+test_truth_tracking_kalman[generic-1000.0]__performance_track_finder.root: ada9cda2ec3c648b144bdaa081d6eff923c80f3d484c4196006e847428cf67a8
 test_truth_tracking_kalman[odd-0.0]__trackstates_fitter.root: c1c0059454d5815af979a17a256bc2470c506178b0ed5ffe195b57479cf79d2d
 test_truth_tracking_kalman[odd-0.0]__tracksummary_fitter.root: 22b271d5187a78b058d370d0bff369e2c5dbd6956f2ffd7a2d4809c77ab43445
 test_truth_tracking_kalman[odd-0.0]__performance_track_finder.root: 39aec6316cceb90e314e16b02947faa691c18f57c3a851a25e547a8fc05a4593
 test_truth_tracking_kalman[odd-1000.0]__trackstates_fitter.root: a2069150737e39724829d76cc91de737be2f444ed08429ddefc7038032442af3
 test_truth_tracking_kalman[odd-1000.0]__tracksummary_fitter.root: 94184e78b1f283eba74190c87fefe1123df0c9927d57ea32d2e2a3a927c126df
 test_truth_tracking_kalman[odd-1000.0]__performance_track_finder.root: 39aec6316cceb90e314e16b02947faa691c18f57c3a851a25e547a8fc05a4593
-test_truth_tracking_gsf[generic]__trackstates_gsf.root: 423bc9d064221433b190c99dc75633f17c97d339a3d0c1aa0a8733432686db99
-test_truth_tracking_gsf[generic]__tracksummary_gsf.root: 6881993dd2f68e102e824ec4c82950a98701ced547603e2e326c22d190c4a1e0
+test_truth_tracking_gsf[generic]__trackstates_gsf.root: 8249d82ebafe9b471cc51400b04ab3bf290ea10540109de7692bd590f52956b8
+test_truth_tracking_gsf[generic]__tracksummary_gsf.root: 4fe7e3e369d2c00244454422259a292c356f2d07d9340896a434b42ef05e55c8
 test_truth_tracking_gsf[odd]__trackstates_gsf.root: a90adb31d19dedea9677864699a955cbae9787b0d55cc5eec5ab8610f0e48074
 test_truth_tracking_gsf[odd]__tracksummary_gsf.root: 14efdb194a6fa6e69587055b6f9818b4c5491235a8b8e96175f07814a3cbde97
 test_particle_gun__particles.root: 8549ba6e20338004ab8ba299fc65e1ee5071985b46df8f77f887cb6fef56a8ec
 test_material_mapping__material-map_tracks.root: 4e1c866038f0c06b099aa74fd01c3d875f07b89f54898f90debd9b558d8e4025
 test_material_mapping__propagation-material.root: 646b8e2bbacec40d0bc4132236f9ab3f03b088e656e6e9b80c47ae03eaf6eab5
 test_volume_material_mapping__material-map-volume_tracks.root: b95561a6247df9e3599a997daa6c1d76461e58f83059b82f2ec27229c9b35e6c
 test_volume_material_mapping__propagation-volume-material.root: b7597dada372d1b4aaec2c4fc3c0db830ce147ecf515c367ac6ba8ffc2708302
-test_digitization_example[smeared]__measurements.root: dcd0ab75b60c6458d25d7211c490a8abe907b53fa4128abe800d93a786a87c10
-test_digitization_example[geometric]__measurements.root: 38017cff7b7e2a0f5d90a23bd99fa289f717380305705545edbfe39757074136
+test_digitization_example[smeared]__measurements.root: 8dea40cccf3acaab2792f8994701e8baafb8b334277a7fdf2c7ff45fdbae776b
+test_digitization_example[geometric]__measurements.root: 8b45ed4abc5d7d6dc87de1921df68981465d5917b1d5d458fb5d105700f13402
 test_digitization_example_input[smeared]__particles.root: 8549ba6e20338004ab8ba299fc65e1ee5071985b46df8f77f887cb6fef56a8ec
-test_digitization_example_input[smeared]__measurements.root: cca36dd6cbbbff48cc8516ed1e8373514bff56ec7594a613c8096b12a5dfd02a
+test_digitization_example_input[smeared]__measurements.root: df0e31749f64f52b7917e44c47fa1eda9e72ef53c44c0e09f3c75b7143b99d24
 test_digitization_example_input[geometric]__particles.root: 8549ba6e20338004ab8ba299fc65e1ee5071985b46df8f77f887cb6fef56a8ec
-test_digitization_example_input[geometric]__measurements.root: a92965e6694005463914a2da8f585b292110c4303a6de06af88aba10f0668836
-test_ckf_tracks_example[generic-full_seeding]__trackstates_ckf.root: fb827ef0f926efc7d52282933b66397a7de7c1f434d73f803925ee54bc818296
-test_ckf_tracks_example[generic-full_seeding]__tracksummary_ckf.root: 066332e3b154715c0189e96cec9d01e428d79e56b6ea30f52a4875af24fb5444
+test_digitization_example_input[geometric]__measurements.root: b4dba5bb5e60d4540c1d07fb297b2add19d779dfcd29737c8d44f208ff0c0522
+test_ckf_tracks_example[generic-full_seeding]__trackstates_ckf.root: edf31a6280aa32b730b98d6867673e1bb33fa02838e8382f6bc68144ff5cfe5f
+test_ckf_tracks_example[generic-full_seeding]__tracksummary_ckf.root: 975ce66c4607740661fbca038e69a1800dd2db9135fd893ec0dba706d34f5be2
 test_ckf_tracks_example[generic-full_seeding]__performance_seeding_trees.root: 0e0676ffafdb27112fbda50d1cf627859fa745760f98073261dcf6db3f2f991e
-test_ckf_tracks_example[generic-truth_estimated]__trackstates_ckf.root: 673d21e96f5837316a76bc3c91b946ffb24ab79747c5f2b1880ded41a0572839
-test_ckf_tracks_example[generic-truth_estimated]__tracksummary_ckf.root: 484db94f15fcb797720b1a67ed03cdeed2c936577127f6cccdc46bda2c023fdb
+test_ckf_tracks_example[generic-truth_estimated]__trackstates_ckf.root: 94e208a458d4a45211a57290fc54313ae5d5e420b8ec514cca82e500f4320b7e
+test_ckf_tracks_example[generic-truth_estimated]__tracksummary_ckf.root: 38ea5737418a1eb98f4cef4731ccdbb4ed009432d04c1fd42e176515bbafb897
 test_ckf_tracks_example[generic-truth_estimated]__performance_seeding.root: 1facb05c066221f6361b61f015cdf0918e94d9f3fce2269ec7b6a4dffeb2bc7e
-test_ckf_tracks_example[generic-truth_smeared]__trackstates_ckf.root: bc26311074d00382d3e3d0d9074b8123dc4e360941ef5df896526b78e09c5778
-test_ckf_tracks_example[generic-truth_smeared]__tracksummary_ckf.root: 17f6dca2f6fdf8fdf9b47f4f02e07f8d99a760ab15e835aa63afa3dae16157fc
+test_ckf_tracks_example[generic-truth_smeared]__trackstates_ckf.root: aae5f59b5bcf45558d8f12d204e34cf3d9ed4b8ca35278b688e5d99906b7670e
+test_ckf_tracks_example[generic-truth_smeared]__tracksummary_ckf.root: ef3ce4ff96553f56866245353dfca17f9be93636c0b05bcc885e268b1bec1409
 test_ckf_tracks_example[odd-full_seeding]__trackstates_ckf.root: ddd7ec1c7161f8daf8d3d00ceb14c39cbf8750e89c72d4c2fd0429e036f8ea9e
 test_ckf_tracks_example[odd-full_seeding]__tracksummary_ckf.root: b9b563a319dc7f607c5668174129ed6e4465ba1897e54fbf0403b0ee93ac1492
 test_ckf_tracks_example[odd-full_seeding]__performance_seeding_trees.root: 43c58577aafe07645e5660c4f43904efadf91d8cda45c5c04c248bbe0f59814f
@@ -72,21 +72,21 @@ test_vertex_fitting_reading[AMVF-False-100]__performance_vertexing.root: 009e4b1
 test_vertex_fitting_reading[AMVF-True-100]__performance_vertexing.root: 2d0dc1e02bfd1f7eaae26ef8ac657ce0291f70c7e4efddd35d171d31988a631e
 test_bfield_writing__solenoid.root: 7ab4d298cd1657c93c90ad7759ea536ad93f52b11cc90f8e3abe611b9cf13234
 test_bfield_writing__solenoid2.root: 948435fab0d2d23b61884acb44e150adc6ab7b432dc41e4e03ae289d8ac30224
-test_root_prop_step_writer[configPosConstructor]__prop_steps.root: d982b17f3c30aa52c7ee80ae7d110ad88c3135bfef3a5279529ab68f5def32bc
-test_root_prop_step_writer[configKwConstructor]__prop_steps.root: d982b17f3c30aa52c7ee80ae7d110ad88c3135bfef3a5279529ab68f5def32bc
-test_root_prop_step_writer[kwargsConstructor]__prop_steps.root: d982b17f3c30aa52c7ee80ae7d110ad88c3135bfef3a5279529ab68f5def32bc
+test_root_prop_step_writer[configPosConstructor]__prop_steps.root: 2bc273f9ec51d800de0b16fd3332ba6453c66d9be8eb3c28ce5856927b295ac3
+test_root_prop_step_writer[configKwConstructor]__prop_steps.root: 2bc273f9ec51d800de0b16fd3332ba6453c66d9be8eb3c28ce5856927b295ac3
+test_root_prop_step_writer[kwargsConstructor]__prop_steps.root: 2bc273f9ec51d800de0b16fd3332ba6453c66d9be8eb3c28ce5856927b295ac3
 test_root_particle_writer[configPosConstructor]__particles.root: 8ca3987523360e4cd52f9bc138e82230996baa105c77ddb2cde775733d8acc4c
 test_root_particle_writer[configKwConstructor]__particles.root: 8ca3987523360e4cd52f9bc138e82230996baa105c77ddb2cde775733d8acc4c
 test_root_particle_writer[kwargsConstructor]__particles.root: 8ca3987523360e4cd52f9bc138e82230996baa105c77ddb2cde775733d8acc4c
-test_root_meas_writer__meas.root: 5902ff01004a7ed50f1ae4c5b1840c3da037bde1c71ee2ac6d3015e94d55aa55
-test_root_simhits_writer[configPosConstructor]__meas.root: 9b43f028dc5b524ab9192562ae5fa4fc0138fad455c112e54f9d155df1f51045
-test_root_simhits_writer[configKwConstructor]__meas.root: 9b43f028dc5b524ab9192562ae5fa4fc0138fad455c112e54f9d155df1f51045
-test_root_simhits_writer[kwargsConstructor]__meas.root: 9b43f028dc5b524ab9192562ae5fa4fc0138fad455c112e54f9d155df1f51045
+test_root_meas_writer__meas.root: 283ccfbbe10bf612f499a9d5c4ca7ac1e1dd4fad7f1629342813ecd36ec06acd
+test_root_simhits_writer[configPosConstructor]__meas.root: 26b51bbd97cd5f915628e150aa286a766a30cecdd511f8476e0c6b2ea62227fa
+test_root_simhits_writer[configKwConstructor]__meas.root: 26b51bbd97cd5f915628e150aa286a766a30cecdd511f8476e0c6b2ea62227fa
+test_root_simhits_writer[kwargsConstructor]__meas.root: 26b51bbd97cd5f915628e150aa286a766a30cecdd511f8476e0c6b2ea62227fa
 test_root_material_writer__material.root: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
-test_root_clusters_writer[configPosConstructor]__clusters.root: 97f04fdd2c0eef4d37dc8732dd25ab49a90bb51925b2638d94826becf5059fae
-test_root_clusters_writer[configKwConstructor]__clusters.root: 97f04fdd2c0eef4d37dc8732dd25ab49a90bb51925b2638d94826becf5059fae
-test_root_clusters_writer[kwargsConstructor]__clusters.root: 97f04fdd2c0eef4d37dc8732dd25ab49a90bb51925b2638d94826becf5059fae
-test_exatrkx[cpu-torch]__performance_track_finding.root: 926d5056c290f1f35d0564e3781c5a1953f35c7f03095ce6420e8814b6e0ab84
-test_exatrkx[gpu-onnx]__performance_track_finding.root: c232d638e53f0f5394d94e8343d1c4f34cf551aaab13db3f8ade4b1fb48b26dd
-test_exatrkx[gpu-torch]__performance_track_finding.root: 9d2de07da83260c3c72d0bbe85f1c268e89579d05151d25f3e9a24dd57687548
+test_root_clusters_writer[configPosConstructor]__clusters.root: 7a6a7927c51dbad1e860f9a6cad45bb66ecf07c63dbecf38196fc16c1d80ea21
+test_root_clusters_writer[configKwConstructor]__clusters.root: 7a6a7927c51dbad1e860f9a6cad45bb66ecf07c63dbecf38196fc16c1d80ea21
+test_root_clusters_writer[kwargsConstructor]__clusters.root: 7a6a7927c51dbad1e860f9a6cad45bb66ecf07c63dbecf38196fc16c1d80ea21
+test_exatrkx[cpu-torch]__performance_track_finding.root: 26dc706b23b693eaf9986d0a6966b38da923cf57e2d99327060090537db27a7b
+test_exatrkx[gpu-onnx]__performance_track_finding.root: f2c4065008ed1ae5c022800bfdeed5fdfa5f8e23126f4ccb68846556f58ed407
+test_exatrkx[gpu-torch]__performance_track_finding.root: 26dc706b23b693eaf9986d0a6966b38da923cf57e2d99327060090537db27a7b
 test_ML_Ambiguity_Solver__performance_ambiML.root: 080e183e758b8593a9c233e2d1b4d213f28fdcb18d82acefdac7c9a5a5763bfc

Examples/Python/tests/test_examples.py

@@ -952,9 +952,9 @@ def test_digitization_example(trk_geo, tmp_path, assert_root_hash, digi_config_f
     else:
         # fmt: off
         filled_entries = [
-            'vol8', 'vol8_lay2', 'vol12_lay8_mod147', 'vol12_lay10', 'vol12_lay10_mod124',
-            'vol12_lay10_mod133', 'vol12_lay12', 'vol12_lay12_mod120', 'vol13',
-            'vol13_lay2', 'vol16_lay2_mod78', 'vol16_lay4', 'vol16_lay6', 'vol16_lay8',
+            'vol8', 'vol8_lay2', 'vol12_lay8_mod117', 'vol12_lay10', 'vol12_lay10_mod154',
+            'vol12_lay10_mod163', 'vol12_lay12', 'vol12_lay12_mod150', 'vol13',
+            'vol13_lay2', 'vol16_lay2_mod53', 'vol16_lay4', 'vol16_lay6', 'vol16_lay8',
             'vol16_lay10', 'vol16_lay12', 'vol17', 'vol17_lay2', 'vol18_lay2',
             'vol18_lay2_mod1', 'vol18_lay2_mod49', 'vol18_lay2_mod86', 'vol18_lay4',
         ]
@@ -1026,9 +1026,9 @@ def test_digitization_example_input(
     else:
         # fmt: off
         filled_entries = [
-            "vol8", "vol8_lay2", "vol12_lay8_mod150", "vol12_lay10_mod114",
-            "vol12_lay10_mod150", "vol12_lay12", "vol12_lay12_mod140",
-            "vol12_lay12_mod141", "vol12_lay12_mod167", "vol13", "vol13_lay2",
+            "vol8", "vol8_lay2", "vol12_lay8_mod120", "vol12_lay10_mod120",
+            "vol12_lay10_mod144", "vol12_lay12", "vol12_lay12_mod111",
+            "vol12_lay12_mod137", "vol12_lay12_mod170", "vol13", "vol13_lay2",
             "vol14_lay2_mod93", "vol14_lay2_mod102", "vol14_lay2_mod112",
             "vol14_lay2_mod118", "vol14_lay4_mod112", "vol14_lay4_mod118",
             "vol14_lay4_mod152", "vol14_lay4_mod161", "vol16_lay4", "vol16_lay6",