fix: RootMeasurementWriter std vs var (#1890)

variance was filled with standard deviation in the RootMeasurementWriter
acts-project · Feb 23, 2023 · 0d9f51b · 0d9f51b
1 parent 0e57ea9
commit 0d9f51b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/Examples/Io/Root/include/ActsExamples/Io/Root/RootMeasurementWriter.hpp b/Examples/Io/Root/include/ActsExamples/Io/Root/RootMeasurementWriter.hpp
@@ -213,16 +213,12 @@ class RootMeasurementWriter final : public WriterT<MeasurementContainer> {
 
       Acts::BoundSymMatrix fullVar =
           m.expander() * m.covariance() * m.expander().transpose();
-      varBound[Acts::eBoundLoc0] =
-          std::sqrt(fullVar(Acts::eBoundLoc0, Acts::eBoundLoc0));
-      varBound[Acts::eBoundLoc1] =
-          std::sqrt(fullVar(Acts::eBoundLoc1, Acts::eBoundLoc1));
-      varBound[Acts::eBoundPhi] =
-          std::sqrt(fullVar(Acts::eBoundPhi, Acts::eBoundPhi));
+      varBound[Acts::eBoundLoc0] = fullVar(Acts::eBoundLoc0, Acts::eBoundLoc0);
+      varBound[Acts::eBoundLoc1] = fullVar(Acts::eBoundLoc1, Acts::eBoundLoc1);
+      varBound[Acts::eBoundPhi] = fullVar(Acts::eBoundPhi, Acts::eBoundPhi);
       varBound[Acts::eBoundTheta] =
-          std::sqrt(fullVar(Acts::eBoundTheta, Acts::eBoundTheta));
-      varBound[Acts::eBoundTime] =
-          std::sqrt(fullVar(Acts::eBoundTime, Acts::eBoundTime));
+          fullVar(Acts::eBoundTheta, Acts::eBoundTheta);
+      varBound[Acts::eBoundTime] = fullVar(Acts::eBoundTime, Acts::eBoundTime);
     }
 
     /// Convenience function to fill the cluster information

diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt
@@ -43,9 +43,9 @@ test_material_mapping__material-map_tracks.root: 2d167433ac10e36e447c26ac9c35eff
 test_material_mapping__propagation-material.root: 3015c064835f84f484f09df1a9a56ce8de471a10cce933952db4530969f905aa
 test_volume_material_mapping__material-map-volume_tracks.root: 1941c8e6a910c9cfa56ad6df6d9cc8930170d6d4f6e56502cf4cdafda0ce91d1
 test_volume_material_mapping__propagation-volume-material.root: 2e3d2685bce1fd75b1d022781e52bcdfd264d8e2fe6bebf05cc280ae78f3f7c6
-test_digitization_example__measurements.root: d6fd33d3182bcd669049fe40d13bc7e80fb9009a3ffa964123460db21384a088
+test_digitization_example__measurements.root: ae9968a05c14790ba57961a4151a7bdefcd50d38ca2434fbdb498c8e4f5f00c1
 test_digitization_example_input__particles.root: b4f74e5a4d9d67d59a6ca7d0e9b42c727aa6baf04c2841bc2d64cc2c4eef8c02
-test_digitization_example_input__measurements.root: 0786f3d1652ee1b464d73468f7bb7507d8b146cafa499b28005a32a87d4ab491
+test_digitization_example_input__measurements.root: 8dd9e59d7e29a222adb9ee5218baac7e0b3861e3cb26b56889f27cc9e87d9539
 test_ckf_tracks_example[generic-full_seeding]__trackstates_ckf.root: 0d5734c60cb1ecee2b830788c839d870d569e4f09e829d491d24eaa3ad679974
 test_ckf_tracks_example[generic-full_seeding]__tracksummary_ckf.root: e387abb1764d7fe1d3ecc971129f0b8577a5b479da2a693a463a4655c7942448
 test_ckf_tracks_example[generic-full_seeding]__performance_seeding_trees.root: 0d5a0f8d9539563efcca8779bba9c747f0a6f01c9789af41af843b4f0917e6e9
@@ -80,7 +80,7 @@ test_root_prop_step_writer[kwargsConstructor]__prop_steps.root: 810b1b94fa751128
 test_root_particle_writer[configPosConstructor]__particles.root: cdda0a2cc454871b8a3c71aa48ac2e5f17263bde6ed195525b13f790b6b81bdc
 test_root_particle_writer[configKwConstructor]__particles.root: cdda0a2cc454871b8a3c71aa48ac2e5f17263bde6ed195525b13f790b6b81bdc
 test_root_particle_writer[kwargsConstructor]__particles.root: cdda0a2cc454871b8a3c71aa48ac2e5f17263bde6ed195525b13f790b6b81bdc
-test_root_meas_writer__meas.root: 8058397a4165f98eb4fd381d799d19b21b342d67fc756ad0880a7b0d83b47720
+test_root_meas_writer__meas.root: 86af06befdbda76ca9bfc8bba5a5971ed0ecf4fc1ace570c2c768d5d968e0742
 test_root_simhits_writer[configPosConstructor]__meas.root: 2f1e5dcd0e2e1bf4c1799c6c9d440d3ba78917b92f81eddd2469cd16ddec965b
 test_root_simhits_writer[configKwConstructor]__meas.root: 2f1e5dcd0e2e1bf4c1799c6c9d440d3ba78917b92f81eddd2469cd16ddec965b
 test_root_simhits_writer[kwargsConstructor]__meas.root: 2f1e5dcd0e2e1bf4c1799c6c9d440d3ba78917b92f81eddd2469cd16ddec965b