fix: CKF flags material surfaces as holes (#1137)

I think after #811, the CKF started to flag all passive material surfaces as holes in the track tip, because both passive surfaces and sensitive surfaces without measurements started to be handled by `addNonSourceLinkState`.

This PR changes this to only flag states as holes if the current surface is in fact sensitive.

/cc @asalzburger @Corentin-Allaire @timadye @noemina

Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp

@@ -952,7 +952,9 @@ class CombinatorialKalmanFilter {
         typeFlags.set(TrackStateFlag::MaterialFlag);
       }
       typeFlags.set(TrackStateFlag::ParameterFlag);
-      typeFlags.set(TrackStateFlag::HoleFlag);
+      if (isSensitive) {
+        typeFlags.set(TrackStateFlag::HoleFlag);
+      }
 
       trackStateProxy.data().ifiltered = trackStateProxy.data().ipredicted;
 

Examples/Python/tests/root_file_hashes.txt

@@ -5,9 +5,9 @@ test_ckf_tracks_example_truth_estimate__performance_seeding_trees.root: 5c0cf9e8
 test_ckf_tracks_example_truth_estimate__performance_seeding_trees.root: 5c0cf9e84af64e6814ab1ddf4cbaf4be6008ad8b2371b5b0241085b19d0fc52c
 test_ckf_tracks_example_truth_estimate__trackstates_ckf.root: ac4485c09a68fca3d056cb8d9adb81695e68d822629e48c71fd2b6d2bbd31f88
 test_ckf_tracks_example_truth_smeared__trackstates_ckf.root: cc6bc5fc00c628f17f2dc9758faef6bb6468e831e796e149fb361438d538ab48
-test_ckf_tracks_example_full_seeding__tracksummary_ckf.root: b0bcba417ad6e4ca08f1d19c1547fe9379f424c309c46df6029b3e3b104117ce
-test_ckf_tracks_example_truth_estimate__tracksummary_ckf.root: b755e5a4a8a8c5fc4733f563e81d264c71d39588c4d3ad47e75a3f110c890002
-test_ckf_tracks_example_truth_smeared__tracksummary_ckf.root: 292c5eed242912ea56d12ffb6be298ccf94f75d4abbbd8c68b78f8ac39b7bd58
+test_ckf_tracks_example_full_seeding__tracksummary_ckf.root: a040e622f16aca8c50d5b298661a2fe977805ccbb5c7345835b01e4b643de17e
+test_ckf_tracks_example_truth_estimate__tracksummary_ckf.root: ce14789746da4484bd1da5a4c338885d4ec273ce2ce3b626c89fbdd2542dd9d5
+test_ckf_tracks_example_truth_smeared__tracksummary_ckf.root: db872141e7940f58acc3e1dc75d0c18c4d1343ec82afadc1286a6458fc894a9a
 
 test_fatras__fatras_particles_final.root: 09b0d46ad7641fc5af97650cdcbf0e6c85966933a2e1b2bfcf7fbb9c6d90b2e1
 test_fatras__fatras_particles_initial.root: 712a41d95ed1fccafccf708afddcd2177793934bb80cd40b1d99b532c7a21031