Skip to content

Commit

Permalink
fix: Fixing units in SeedFinderConfig (#1176)
Browse files Browse the repository at this point in the history
This PR fixes the units of `deltaRMiddleSPRange` to external ACTS units and adds `deltaRMiddleSPRange`, `deltaRMinTopSP`, `deltaRMaxTopSP`, `deltaRMinBottomSP` and `deltaRMaxBottomSP` to the `toInternalUnits` method.
  • Loading branch information
LuisFelipeCoelho committed Mar 2, 2022
1 parent 11f59e3 commit 3ee4e2e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion Core/include/Acts/Seeding/SeedfinderConfig.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ struct SeedfinderConfig {
// radial range for middle SP
std::vector<std::vector<float>> rRangeMiddleSP;
bool useVariableMiddleSPRange = false;
float deltaRMiddleSPRange = 10.;
float deltaRMiddleSPRange = 10. * Acts::UnitConstants::mm;

// seed confirmation
bool seedConfirmation = false;
Expand Down Expand Up @@ -146,6 +146,11 @@ struct SeedfinderConfig {
config.minPt /= 1_MeV;
config.deltaRMin /= 1_mm;
config.deltaRMax /= 1_mm;
config.deltaRMinTopSP /= 1_mm;
config.deltaRMaxTopSP /= 1_mm;
config.deltaRMinBottomSP /= 1_mm;
config.deltaRMaxBottomSP /= 1_mm;
config.deltaRMiddleSPRange /= 1_mm;
config.impactMax /= 1_mm;
config.maxPtScattering /= 1_MeV; // correct?
config.collisionRegionMin /= 1_mm;
Expand Down

0 comments on commit 3ee4e2e

Please sign in to comment.