Skip to content

Commit

Permalink
fix: remove deleted track selector params in python (#1907)
Browse files Browse the repository at this point in the history
after #1874 some track selector params were not wired correctly
  • Loading branch information
andiwand committed Mar 1, 2023
1 parent 423f549 commit 4e5f614
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 2 additions & 6 deletions Examples/Python/python/acts/examples/reconstruction.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,8 @@
"absEta",
"pt",
"phi",
"removeNeutral",
"removeCharged",
],
defaults=[(None, None)] * 7 + [None] * 2,
defaults=[(None, None)] * 7,
)

CKFPerformanceConfig = namedtuple(
Expand Down Expand Up @@ -894,7 +892,7 @@ def addCKFTracks(
the output folder for the Csv output, None triggers no output
outputDirRoot : Path|str, path, None
the output folder for the Root output, None triggers no output
trackSelectorRanges : TrackSelectorRanges(loc0, loc1, time, eta, absEta, pt, phi, removeNeutral, removeCharged)
trackSelectorRanges : TrackSelectorRanges(loc0, loc1, time, eta, absEta, pt, phi)
TrackSelector configuration. Each range is specified as a tuple of (min,max).
Defaults of no cuts specified in Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackSelector.hpp
writeTrajectories : bool, True
Expand Down Expand Up @@ -1115,8 +1113,6 @@ def addTrackSelection(
absEtaMax=trackSelectorRanges.absEta[1],
ptMin=trackSelectorRanges.pt[0],
ptMax=trackSelectorRanges.pt[1],
removeCharged=trackSelectorRanges.removeCharged,
removeNeutral=trackSelectorRanges.removeNeutral,
),
)

Expand Down
2 changes: 1 addition & 1 deletion Examples/Scripts/Python/full_chain_itk.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
trackingGeometry,
field,
CKFPerformanceConfig(ptMin=1.0 * u.GeV if ttbar_pu200 else 0.0, nMeasurementsMin=6),
TrackSelectorRanges(pt=(1.0 * u.GeV, None), absEta=(None, 4.0), removeNeutral=True),
TrackSelectorRanges(pt=(1.0 * u.GeV, None), absEta=(None, 4.0)),
outputDirRoot=outputDir,
)

Expand Down

0 comments on commit 4e5f614

Please sign in to comment.