feat: Adding inner and outer tube covers for disc approach descriptor (…

…#1188) This allows to fix propagation problems seen in the inclined section of the ITk tracking geometry. FYI: @timadye @niermann999 @paulgessinger @asalzburger
acts-project · Mar 29, 2022 · 5c98af7 · 5c98af7
1 parent 89ca4c8
commit 5c98af7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/Core/src/Geometry/DiscLayer.cpp b/Core/src/Geometry/DiscLayer.cpp
@@ -77,6 +77,10 @@ void Acts::DiscLayer::buildApproachDescriptor() {
         bSurfaces.at(negativeFaceXY)->surfaceRepresentation().getSharedPtr());
     aSurfaces.push_back(
         bSurfaces.at(positiveFaceXY)->surfaceRepresentation().getSharedPtr());
+    aSurfaces.push_back(
+        bSurfaces.at(tubeInnerCover)->surfaceRepresentation().getSharedPtr());
+    aSurfaces.push_back(
+        bSurfaces.at(tubeOuterCover)->surfaceRepresentation().getSharedPtr());
     // create an ApproachDescriptor with Boundary surfaces
     m_approachDescriptor =
         std::make_unique<const GenericApproachDescriptor>(std::move(aSurfaces));

diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt
@@ -1,13 +1,12 @@
 
 test_ckf_tracks_example_full_seeding__performance_seeding_trees.root: 938bcc9b9425b12c620f5d0efa2c592817dfe92a18c309e97aa9d87412918620
-test_ckf_tracks_example_full_seeding__trackstates_ckf.root: f7cd38850d5334326cd5be9b9428435ed59fb3617787a97ec306239b458d921b
+test_ckf_tracks_example_full_seeding__trackstates_ckf.root: 2b07a0126ed3ec5df5551f4550dbfcee4482cd11b9bff5bac58b48b85f24409c
 test_ckf_tracks_example_truth_estimate__performance_seeding_trees.root: 5c0cf9e84af64e6814ab1ddf4cbaf4be6008ad8b2371b5b0241085b19d0fc52c
-test_ckf_tracks_example_truth_estimate__performance_seeding_trees.root: 5c0cf9e84af64e6814ab1ddf4cbaf4be6008ad8b2371b5b0241085b19d0fc52c
-test_ckf_tracks_example_truth_estimate__trackstates_ckf.root: e13732621f876af3991ad825769e5b4e0bac91dddf8591f256d63bb882f5e860
+test_ckf_tracks_example_truth_estimate__trackstates_ckf.root: 82bc7c860b664d5b6f36b7d892ef599a1905cc335554e98ca7b95f6363ce6e9d
 test_ckf_tracks_example_truth_smeared__trackstates_ckf.root: cc6bc5fc00c628f17f2dc9758faef6bb6468e831e796e149fb361438d538ab48
-test_ckf_tracks_example_full_seeding__tracksummary_ckf.root: 6ac61a86ded835406ad5d97b26503c789933bb1fca3e5131061149a3cd3fa14b
-test_ckf_tracks_example_truth_estimate__tracksummary_ckf.root: 8d7872c55b49c73130c97ce1df51eb4846cc1f080c4c834516278ffcad8f7e3e
-test_ckf_tracks_example_truth_smeared__tracksummary_ckf.root: f7a65614bfdd7daed69e764f22c03999aca3fab6b8ce698eb93767e33f7afbe4
+test_ckf_tracks_example_full_seeding__tracksummary_ckf.root: fd2cda11a1b39a939205ccc0c6af3e446b7c79946cbbb2b4937f45536ea9273c
+test_ckf_tracks_example_truth_estimate__tracksummary_ckf.root: 93e71ec6456caac6c496c56d240da1e77153a545a12692deb0a826f0a31bbf58
+test_ckf_tracks_example_truth_smeared__tracksummary_ckf.root: c63633077f31bb38a7e0c0c4db0eca215751ce5e1c7e1ac933927e9feeec15e4
 
 
 
@@ -24,14 +23,14 @@ test_particle_gun__particles.root: 78a89f365177423d0834ea6f1bd8afe1488e72b12a250
 test_digitization_example__measurements.root: f2dd54cd8315e4656136571d4802a69293d7feb71f427706410b8f0d2ad76265
 
 test_material_recording__geant4_material_tracks.root: 166dfb9f7a0a19d2206cf7c5ada02189e0b04a49ec7c25a59007e3ee23a62035
-test_material_mapping__material-map_tracks.root: 525ecf8f38d515e23efc480fb3d75eef56403360e66e20b8f7676ee2c8e47134
+test_material_mapping__material-map_tracks.root: 80beaaf4b9acee9eef6f2bb2094d1c819edb07f22e949833a0dc4143a697ad32
 test_material_mapping__propagation-material.root: 15d5dfd89583b965ec5a2625126a190b4af92f21b4f2f9ce2946e98bf8dff34a
 test_volume_material_mapping__material-map-volume_tracks.root: 14815e3f42a64c140450302f06a4381ede147ee4edbb8a88f3dfac7e7ab53fa7
-test_volume_material_mapping__propagation-volume-material.root: 7219bae942b0d0dc252e4f42e2cec01d7500fcb28bd9b17e140613bbd7e5a49a
+test_volume_material_mapping__propagation-volume-material.root: 47b488e258ca4c964ba9f68a65e4ea576bc096f2c8476b1363b9f98b5cc96820
 
-test_root_prop_step_writer[configPosConstructor]__prop_steps.root: 3bb94cb1100996445e5a91ab86221f1a56040ef800894bc0279462422c734e60
-test_root_prop_step_writer[configKwConstructor]__prop_steps.root: 3bb94cb1100996445e5a91ab86221f1a56040ef800894bc0279462422c734e60
-test_root_prop_step_writer[kwargsConstructor]__prop_steps.root: 3bb94cb1100996445e5a91ab86221f1a56040ef800894bc0279462422c734e60
+test_root_prop_step_writer[configPosConstructor]__prop_steps.root: 398c217a6a3c9bd11cea3ecc2b825b2c6738f88c8f7c385cd2503ee8893b35a5
+test_root_prop_step_writer[configKwConstructor]__prop_steps.root: 398c217a6a3c9bd11cea3ecc2b825b2c6738f88c8f7c385cd2503ee8893b35a5
+test_root_prop_step_writer[kwargsConstructor]__prop_steps.root: 398c217a6a3c9bd11cea3ecc2b825b2c6738f88c8f7c385cd2503ee8893b35a5
 test_root_particle_writer[configPosConstructor]__particles.root: 7d2c8cce6f491c22ce149b526866bdfa8795cfac20105a7c33fce096d52d47d8
 test_root_particle_writer[configKwConstructor]__particles.root: 7d2c8cce6f491c22ce149b526866bdfa8795cfac20105a7c33fce096d52d47d8
 test_root_particle_writer[kwargsConstructor]__particles.root: 7d2c8cce6f491c22ce149b526866bdfa8795cfac20105a7c33fce096d52d47d8