Skip to content

Commit

Permalink
feat: Add variable axis type for SpacePointGrid - Follow-up (#1005)
Browse files Browse the repository at this point in the history
Address minor comments related to #976.
  • Loading branch information
LuisFelipeCoelho committed Sep 28, 2021
1 parent 60e036d commit 69d74c4
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions Core/include/Acts/Seeding/SpacePointGrid.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ Acts::SpacePointGridCreator::createGrid(
// intersection of helix and max detector radius minus maximum R distance
// from middle SP to top SP
float innerAngle = 0;
float Rmin = config.rMax;
float rMin = config.rMax;
if (config.rMax > config.deltaRMax) {
Rmin = config.rMax - config.deltaRMax;
rMin = config.rMax - config.deltaRMax;
float innerCircleR2 =
(config.rMax - config.deltaRMax) * (config.rMax - config.deltaRMax);
float xInner = innerCircleR2 / (2 * minHelixRadius);
Expand All @@ -46,7 +46,7 @@ Acts::SpacePointGridCreator::createGrid(

// evaluating the azimutal deflection including the maximum impact parameter
float deltaAngleWithMaxD0 =
std::abs(std::asin(config.impactMax / (Rmin)) -
std::abs(std::asin(config.impactMax / (rMin)) -
std::asin(config.impactMax / config.rMax));

// evaluating delta Phi based on the inner and outer angle, and the azimutal
Expand Down Expand Up @@ -86,8 +86,7 @@ Acts::SpacePointGridCreator::createGrid(
} else {
// Use the zBinEdges defined in the config
for (auto& bin : config.zBinEdges) {
AxisScalar edge = bin;
zValues.push_back(edge);
zValues.push_back(bin);
}
}

Expand Down

0 comments on commit 69d74c4

Please sign in to comment.