fix: MultiTrajectory parameters and covariance constness (#2009)

I believe these functions were not fully usable before if used through a const `MultiTrajectory`.
acts-project · Apr 5, 2023 · 76e9db6 · 76e9db6
1 parent ff07dd9
commit 76e9db6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Core/include/Acts/EventData/MultiTrajectory.hpp b/Core/include/Acts/EventData/MultiTrajectory.hpp
@@ -508,14 +508,14 @@ class TrackStateProxy {
   /// first parameters that are set in this order: predicted -> filtered ->
   /// smoothed
   /// @return one of predicted, filtered or smoothed parameters
-  Parameters parameters() const;
+  ConstParameters parameters() const;
 
   /// Track parameters covariance matrix. This tries to be somewhat smart and
   /// return the
   /// first parameters that are set in this order: predicted -> filtered ->
   /// smoothed
   /// @return one of predicted, filtered or smoothed covariances
-  Covariance covariance() const;
+  ConstCovariance covariance() const;
 
   /// Predicted track parameters vector
   /// @return The predicted parameters

diff --git a/Core/include/Acts/EventData/MultiTrajectory.ipp b/Core/include/Acts/EventData/MultiTrajectory.ipp
@@ -47,7 +47,8 @@ TrackStatePropMask TrackStateProxy<D, M, ReadOnly>::getMask() const {
 }
 
 template <typename D, size_t M, bool ReadOnly>
-inline auto TrackStateProxy<D, M, ReadOnly>::parameters() const -> Parameters {
+inline auto TrackStateProxy<D, M, ReadOnly>::parameters() const
+    -> ConstParameters {
   if (hasSmoothed()) {
     return smoothed();
   } else if (hasFiltered()) {
@@ -58,7 +59,8 @@ inline auto TrackStateProxy<D, M, ReadOnly>::parameters() const -> Parameters {
 }
 
 template <typename D, size_t M, bool ReadOnly>
-inline auto TrackStateProxy<D, M, ReadOnly>::covariance() const -> Covariance {
+inline auto TrackStateProxy<D, M, ReadOnly>::covariance() const
+    -> ConstCovariance {
   if (hasSmoothed()) {
     return smoothedCovariance();
   } else if (hasFiltered()) {