Skip to content

Commit

Permalink
refactor: revisit FullBilloirVertexFitter (#2196)
Browse files Browse the repository at this point in the history
In this PR we improve the `FullBilloirVertexFitter`.  We resolve issue #2246 and add time to the unit test. In addition, variable names are changed to match the reference, comments improved, and bits of code rewritten.
  • Loading branch information
felix-russo committed Jul 18, 2023
1 parent b235828 commit 7e5b2ce
Show file tree
Hide file tree
Showing 3 changed files with 324 additions and 401 deletions.
12 changes: 10 additions & 2 deletions Core/include/Acts/Vertexing/FullBilloirVertexFitter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,21 @@ namespace Acts {
///
/// @brief Vertex fitter class implementing the Billoir vertex fitter
///
/// This class implements the Billoir vertex fitter:
/// This class implements the Billoir vertex fitter from Ref. (1). It is also
/// useful to have a look at Ref. (2). Note that the Billoir vertex fitter
/// outputs one 4D vertex position and nTrack momenta at this very point.
///
/// Fast vertex fitting with a local parametrization of tracks
/// Ref. (1):
/// Fast vertex fitting with a local parametrization of tracks.
/// Author(s) Billoir, P ; Qian, S
/// In: Nucl. Instrum. Methods Phys. Res., A 311 (1992) 139-150
/// DOI 10.1016/0168-9002(92)90859-3
///
/// Ref. (2):
/// Pattern Recognition, Tracking and Vertex Reconstruction in Particle
/// Detectors.
/// Author(s) Fruehwirth, R ; Strandli, A
///
/// @tparam input_track_t Track object type
/// @tparam linearizer_t Track linearizer type
template <typename input_track_t, typename linearizer_t>
Expand Down

0 comments on commit 7e5b2ce

Please sign in to comment.