Skip to content

Commit

Permalink
refactor: Change Variables Name in order not to start with _ (#1936)
Browse files Browse the repository at this point in the history
This generates a huge amount of compilation warnings during Acts Tag bumps in Athena (related only to the nomenclature) that may hide real warnings we should pay attention to.

Absolutely no change in the code behaviour
  • Loading branch information
CarloVarni committed Mar 10, 2023
1 parent 0b9004f commit 7f581ed
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Core/include/Acts/MagneticField/detail/SmallObjectCache.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,18 +93,18 @@ class SmallObjectCache {
void moveConstruct(void* from, void* to) const override {
assert(from != nullptr && "Source is null");
assert(to != nullptr && "Target is null");
T* _from = static_cast<T*>(from);
/*T* ptr =*/new (to) T(std::move(*_from));
T* fromValue = static_cast<T*>(from);
/*T* ptr =*/new (to) T(std::move(*fromValue));
}

void move(void* from, void* to) const override {
assert(from != nullptr && "Source is null");
assert(to != nullptr && "Target is null");

T* _from = static_cast<T*>(from);
T* _to = static_cast<T*>(to);
T* fromValue = static_cast<T*>(from);
T* toValue = static_cast<T*>(to);

(*_to) = std::move(*_from);
(*toValue) = std::move(*fromValue);
}
};

Expand Down

0 comments on commit 7f581ed

Please sign in to comment.