Skip to content

Commit

Permalink
feat: Athena Ambiguity Resolution Algorithm (#3139)
Browse files Browse the repository at this point in the history
This is the PR for Ambiguity Resolution algorithm inspired from ATLAS-Athena

In this PR we are implementing a score based Ambiguity resolution which takes inspiration from ATLAS Ambiguity resolution.

Along with the core Functionality, I have added Algorithm function in Examples, made necessary modification for Pybind and run_full_chain_odd.py and made unit tests.

To replace the detector dependent hard-coding a config file in *.json format can be used. Hence a Json Config Reader is also included in this PR.


This Project was guided by Corentin, Carlo and David.

Regards
Ragansu.
  • Loading branch information
Ragansu committed May 7, 2024
1 parent 320253c commit 91e7033
Show file tree
Hide file tree
Showing 18 changed files with 1,534 additions and 47 deletions.
@@ -0,0 +1,229 @@
// This file is part of the Acts project.
//
// Copyright (C) 2024 CERN for the benefit of the Acts project
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.

#pragma once

#include "Acts/Definitions/Units.hpp"
#include "Acts/EventData/TrackContainer.hpp"
#include "Acts/Utilities/Delegate.hpp"
#include "Acts/Utilities/Logger.hpp"

#include <cstddef>
#include <map>
#include <memory>
#include <string>
#include <tuple>
#include <vector>

#include <boost/container/flat_map.hpp>
#include <boost/container/flat_set.hpp>

namespace Acts {

/// Generic implementation of the score based ambiguity resolution.
/// The alhorithm is based on the following steps:
/// 1) Compute the initial state of the tracks
/// 2) Compute the score of each track
/// 3) Removes hits that are not good enough for each track
/// 4) Remove tracks that have a score below a certain threshold or not have
/// enough hits
/// 5) Remove tracks that are not good enough based on cuts Contains method for
/// data preparations
class ScoreBasedAmbiguityResolution {
public:
/// @brief Detector configuration struct : contains the configuration for each detector
///
/// The configuration can be saved in a json file and loaded from there.
///
struct DetectorConfig {
int hitsScoreWeight = 0;
int holesScoreWeight = 0;
int outliersScoreWeight = 0;
int otherScoreWeight = 0;

std::size_t minHits = 0;
std::size_t maxHits = 0;
std::size_t maxHoles = 0;
std::size_t maxOutliers = 0;
std::size_t maxSharedHits = 0;

/// if true, the shared hits are considered as bad hits for this detector
bool sharedHitsFlag = false;

std::size_t detectorId = 0;

/// a list of values from 0 to 1, the higher number of hits, higher value
/// in the list is multiplied to ambuiguity score applied only if
/// useAmbiguityFunction is true
std::vector<double> factorHits = {1.0};

/// a list of values from 0 to 1, the higher number of holes, lower value
/// in the list is multiplied to ambuiguity score applied only if
/// useAmbiguityFunction is true
std::vector<double> factorHoles = {1.0};
};

/// @brief TrackFeatures struct : contains the features that are counted for each track.
///
/// The trackFeatures is used to compute the score of each track
struct TrackFeatures {
std::size_t nHits = 0;
std::size_t nHoles = 0;
std::size_t nOutliers = 0;
std::size_t nSharedHits = 0;
};

/// @brief MeasurementInfo : contains the measurement ID and the detector ID
struct MeasurementInfo {
std::size_t iMeasurement = 0;
std::size_t detectorId = 0;
bool isOutlier = false;
};

/// @brief Configuration struct : contains the configuration for the ambiguity resolution.
struct Config {
std::map<std::size_t, std::size_t> volumeMap = {{0, 0}};
std::vector<DetectorConfig> detectorConfigs;
/// minimum score for any track
double minScore = 0;
/// minimum score for shared tracks
double minScoreSharedTracks = 0;
/// maximum number of shared tracks per measurement
std::size_t maxSharedTracksPerMeasurement = 10;
/// maximum number of shared hit per track
std::size_t maxShared = 5;

double pTMin = 0 * UnitConstants::GeV;
double pTMax = 1e5 * UnitConstants::GeV;

double phiMin = -M_PI * UnitConstants::rad;
double phiMax = M_PI * UnitConstants::rad;

double etaMin = -5;
double etaMax = 5;

// if true, the ambiguity score is computed based on a different function.
bool useAmbiguityFunction = false;
};

/// @brief OptionalCuts struct : contains the optional cuts to be applied.
///
/// The optional cuts,weights and score are used to remove tracks that are not
/// good enough, based on some criteria. Users are free to add their own cuts
/// with the help of this struct.
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
struct OptionalCuts {
using OptionalFilter =
std::function<bool(const Acts::TrackProxy<track_container_t, traj_t,
holder_t, ReadOnly>&)>;

using OptionalScoreModifier = std::function<void(
const Acts::TrackProxy<track_container_t, traj_t, holder_t, ReadOnly>&,
double&)>;
std::vector<OptionalFilter> cuts = {};
std::vector<OptionalScoreModifier> weights = {};

/// applied only if useAmbiguityFunction is true
std::vector<OptionalScoreModifier> scores = {};
};

ScoreBasedAmbiguityResolution(
const Config& cfg,
std::unique_ptr<const Logger> logger =
getDefaultLogger("ScoreBasedAmbiguityResolution", Logging::INFO))
: m_cfg{cfg}, m_logger{std::move(logger)} {}

/// Compute the initial state of the tracks.
///
/// @param tracks is the input track container
/// @param sourceLinkHash is the source links
/// @param sourceLinkEquality is the equality function for the source links
/// @param trackFeaturesVectors is the trackFeatures map from detector ID to trackFeatures
/// @return a vector of the initial state of the tracks
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, typename source_link_hash_t,
typename source_link_equality_t>
std::vector<std::vector<MeasurementInfo>> computeInitialState(
const TrackContainer<track_container_t, traj_t, holder_t>& tracks,
source_link_hash_t sourceLinkHash,
source_link_equality_t sourceLinkEquality,
std::vector<std::vector<TrackFeatures>>& trackFeaturesVectors) const;

/// Compute the score of each track.
///
/// @param tracks is the input track container
/// @param trackFeaturesVectors is the trackFeatures map from detector ID to trackFeatures
/// @param optionalCuts is the user defined optional cuts to be applied.
/// @return a vector of scores for each track
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
std::vector<double> simpleScore(
const TrackContainer<track_container_t, traj_t, holder_t>& tracks,
const std::vector<std::vector<TrackFeatures>>& trackFeaturesVectors,
const OptionalCuts<track_container_t, traj_t, holder_t, ReadOnly>&
optionalCuts = {}) const;

/// Compute the score of each track based on the ambiguity function.
///
/// @param tracks is the input track container
/// @param trackFeaturesVectors is the trackFeatures map from detector ID to trackFeatures
/// @param optionalCuts is the user defined optional cuts to be applied.
/// @return a vector of scores for each track
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
std::vector<double> ambiguityScore(
const TrackContainer<track_container_t, traj_t, holder_t>& tracks,
const std::vector<std::vector<TrackFeatures>>& trackFeaturesVectors,
const OptionalCuts<track_container_t, traj_t, holder_t, ReadOnly>&
optionalCuts = {}) const;

/// Remove hits that are not good enough for each track and removes tracks
/// that have a score below a certain threshold or not enough hits.
///
/// @brief Remove tracks that are not good enough based on cuts
/// @param trackScore is the score of each track
/// @param trackFeaturesVectors is the trackFeatures map for each track
/// @param measurementsPerTrack is the list of measurements for each track
/// @return a vector of IDs of the tracks we want to keep
std::vector<bool> getCleanedOutTracks(
const std::vector<double>& trackScore,
const std::vector<std::vector<TrackFeatures>>& trackFeaturesVectors,
const std::vector<std::vector<MeasurementInfo>>& measurementsPerTrack)
const;

/// Remove tracks that are bad based on cuts and weighted scores.
///
/// @brief Remove tracks that are not good enough
/// @param tracks is the input track container
/// @param measurementsPerTrack is the list of measurements for each track
/// @param trackFeaturesVectors is the map of detector id to trackFeatures for each track
/// @param optionalCuts is the optional cuts to be applied
/// @return a vector of IDs of the tracks we want to keep
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
std::vector<int> solveAmbiguity(
const TrackContainer<track_container_t, traj_t, holder_t>& tracks,
const std::vector<std::vector<MeasurementInfo>>& measurementsPerTrack,
const std::vector<std::vector<TrackFeatures>>& trackFeaturesVectors,
const OptionalCuts<track_container_t, traj_t, holder_t, ReadOnly>&
optionalCuts = {}) const;

private:
Config m_cfg;

/// Logging instance
std::unique_ptr<const Logger> m_logger = nullptr;

/// Private access to logging instance
const Logger& logger() const;
};

} // namespace Acts

#include "Acts/AmbiguityResolution/ScoreBasedAmbiguityResolution.ipp"

0 comments on commit 91e7033

Please sign in to comment.