fix: Enable G4 based python tests and fix them (#1044)

CI did not run the python G4 based tests because of a missing setup script. This revealed an off-by-one error in the material track reading.
acts-project · Oct 21, 2021 · 9a2dea0 · 9a2dea0
1 parent 43d0b76
commit 9a2dea0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml
@@ -63,6 +63,8 @@ jobs:
           ${SETUP} 
           && source /usr/local/bin/thisroot.sh
           && source /usr/local/bin/thisdd4hep_only.sh
+          && /usr/local/bin/download_geant4_data.sh
+          && source /usr/local/bin/geant4.sh
           && source build/python/setup.sh 
           && pip3 install pytest
           && pytest -rFs

diff --git a/Examples/Io/Root/src/RootMaterialTrackReader.cpp b/Examples/Io/Root/src/RootMaterialTrackReader.cpp
@@ -62,7 +62,7 @@ ActsExamples::RootMaterialTrackReader::RootMaterialTrackReader(
                               << "'.");
   }
 
-  m_events = m_inputChain->GetMaximum("event_id");
+  m_events = m_inputChain->GetMaximum("event_id") + 1;
   ACTS_DEBUG("The full chain has " << m_events << " entries.");
 
   // If the events are not in order, get the entry numbers for ordered events

diff --git a/Examples/Python/tests/test_reader.py b/Examples/Python/tests/test_reader.py
@@ -153,7 +153,7 @@ def test_root_material_track_reader(material_recording):
 
     s.run()
 
-    assert alg.events_seen == 198
+    assert alg.events_seen == 2
 
 
 @pytest.mark.csv