fix(HepMC3): Remove shared_ptr to stack variable (#879)

In a few spots in the HepMC3 examples, `std::shared_ptr` were created with raw pointers to stack variables. This clearly results in `std::shared_ptr` calling `delete` on cleared memory.
acts-project · Jul 15, 2021 · a99ae08 · a99ae08
1 parent 9a38f3f
commit a99ae08
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/Examples/Io/HepMC3/src/HepMC3Event.cpp b/Examples/Io/HepMC3/src/HepMC3Event.cpp
@@ -22,10 +22,11 @@ HepMC3::GenParticlePtr actsParticleToGen(
   const auto mom4 = actsParticle->fourMomentum();
   const HepMC3::FourVector vec(mom4[0], mom4[1], mom4[2], mom4[3]);
   // Create HepMC3::GenParticle
-  HepMC3::GenParticle genParticle(vec, actsParticle->pdg());
-  genParticle.set_generated_mass(actsParticle->mass());
+  auto genParticle =
+      std::make_shared<HepMC3::GenParticle>(vec, actsParticle->pdg());
+  genParticle->set_generated_mass(actsParticle->mass());
 
-  return std::shared_ptr<HepMC3::GenParticle>(&genParticle);
+  return genParticle;
 }
 
 /// @brief Converts an Acts vertex to a HepMC3::GenVertexPtr
@@ -39,21 +40,21 @@ HepMC3::GenVertexPtr createGenVertex(
       actsVertex->position4[2], actsVertex->position4[3]);
 
   // Create vertex
-  HepMC3::GenVertex genVertex(vec);
+  auto genVertex = std::make_shared<HepMC3::GenVertex>(vec);
 
   // Store incoming particles
   for (auto& particle : actsVertex->incoming) {
     HepMC3::GenParticlePtr genParticle = actsParticleToGen(
         std::make_shared<ActsExamples::SimParticle>(particle));
-    genVertex.add_particle_in(genParticle);
+    genVertex->add_particle_in(genParticle);
   }
   // Store outgoing particles
   for (auto& particle : actsVertex->outgoing) {
     HepMC3::GenParticlePtr genParticle = actsParticleToGen(
         std::make_shared<ActsExamples::SimParticle>(particle));
-    genVertex.add_particle_out(genParticle);
+    genVertex->add_particle_out(genParticle);
   }
-  return std::shared_ptr<HepMC3::GenVertex>(&genVertex);
+  return genVertex;
 }
 
 /// @brief Compares an Acts vertex with a HepMC3::GenVertex

diff --git a/Examples/Io/HepMC3/src/HepMC3Vertex.cpp b/Examples/Io/HepMC3/src/HepMC3Vertex.cpp
@@ -35,10 +35,11 @@ HepMC3::GenParticlePtr actsParticleToGen(
   const auto mom = actsParticle->fourMomentum();
   const HepMC3::FourVector vec(mom[0], mom[1], mom[2], mom[3]);
   // Create HepMC3::GenParticle
-  HepMC3::GenParticle genParticle(vec, actsParticle->pdg());
-  genParticle.set_generated_mass(actsParticle->mass());
+  auto genParticle =
+      std::make_shared<HepMC3::GenParticle>(vec, actsParticle->pdg());
+  genParticle->set_generated_mass(actsParticle->mass());
 
-  return std::shared_ptr<HepMC3::GenParticle>(&genParticle);
+  return genParticle;
 }
 
 /// @brief Finds a HepMC3::GenParticle from a list that matches an