chore: clang-tidy modernize-use-using (#1342)

Reduce clang-tidy warnings
acts-project · Jul 27, 2022 · ca0dcd6 · ca0dcd6
1 parent 9a41907
commit ca0dcd6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,4 +1,4 @@
 ---
-Checks: '-*,readability-container-size-empty,readability-implicit-bool-cast,readability-implicit-bool-conversion,modernize-use-equals-default,modernize-use-override,readability-braces-around-statements'
+Checks: '-*,readability-container-size-empty,readability-implicit-bool-cast,readability-implicit-bool-conversion,modernize-use-equals-default,modernize-use-override,modernize-use-using,readability-braces-around-statements'
 HeaderFilterRegex: '.*(?<!nlohmann\/json)\.(hpp|cpp|ipp)$'
 AnalyzeTemporaryDtors: true
diff --git a/CI/clang_tidy/limits.yml b/CI/clang_tidy/limits.yml
@@ -2,7 +2,7 @@ limits:
   # "readability-inconsistent-declaration-parameter-name": 0
   # "readability-named-parameter": 0
   "readability-container-size-empty": 0
-  # "modernize-use-using": 0
+  "modernize-use-using": 0
   "readability-braces-around-statements": 0
   "modernize-use-override": 0
   "modernize-use-equals-default" : 0

diff --git a/Tests/UnitTests/Core/Utilities/HelpersTests.cpp b/Tests/UnitTests/Core/Utilities/HelpersTests.cpp
@@ -155,11 +155,11 @@ BOOST_AUTO_TEST_CASE(test_matrix_dimension_switch) {
   }
 }
 
-typedef std::tuple<std::pair<ActsMatrix<3, 3>, ActsMatrix<3, 3>>,
-                   std::pair<ActsMatrix<4, 4>, ActsMatrix<4, 4>>,
-                   std::pair<ActsMatrix<8, 8>, ActsMatrix<8, 8>>,
-                   std::pair<ActsMatrix<8, 7>, ActsMatrix<7, 4>>>
-    MatrixProductTypes;
+using MatrixProductTypes =
+    std::tuple<std::pair<ActsMatrix<3, 3>, ActsMatrix<3, 3>>,
+               std::pair<ActsMatrix<4, 4>, ActsMatrix<4, 4>>,
+               std::pair<ActsMatrix<8, 8>, ActsMatrix<8, 8>>,
+               std::pair<ActsMatrix<8, 7>, ActsMatrix<7, 4>>>;
 
 BOOST_AUTO_TEST_CASE_TEMPLATE(BlockedMatrixMultiplication, Matrices,
                               MatrixProductTypes) {

diff --git a/Tests/UnitTests/Core/Vertexing/ZScanVertexFinderTests.cpp b/Tests/UnitTests/Core/Vertexing/ZScanVertexFinderTests.cpp
@@ -85,8 +85,8 @@ BOOST_AUTO_TEST_CASE(zscan_finder_test) {
     // Set up propagator with void navigator
     auto propagator = std::make_shared<Propagator>(stepper);
 
-    typedef FullBilloirVertexFitter<BoundTrackParameters, Linearizer_t>
-        BilloirFitter;
+    using BilloirFitter =
+        FullBilloirVertexFitter<BoundTrackParameters, Linearizer_t>;
 
     // Create perigee surface
     std::shared_ptr<PerigeeSurface> perigeeSurface =
@@ -210,7 +210,7 @@ BOOST_AUTO_TEST_CASE(zscan_finder_usertrack_test) {
     // Set up propagator with void navigator
     auto propagator = std::make_shared<Propagator>(stepper);
 
-    typedef FullBilloirVertexFitter<InputTrack, Linearizer_t> BilloirFitter;
+    using BilloirFitter = FullBilloirVertexFitter<InputTrack, Linearizer_t>;
 
     // Create perigee surface
     std::shared_ptr<PerigeeSurface> perigeeSurface =