Skip to content

Commit

Permalink
fix: bug in ITk config (#1961)
Browse files Browse the repository at this point in the history
Recently I changed deltaZMax in ITk configuration, but I should have changed only for PPP and not for SSS as well.
@CarloVarni I believe this is the reason for the higher number of SSS seeds that we were seeing. Sorry for that
  • Loading branch information
LuisFelipeCoelho committed Mar 19, 2023
1 parent c1785e0 commit d2882c8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Examples/Python/python/acts/examples/itk.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ def itkSeedingAlgConfig(inputSpacePointsType: InputSpacePointsType):
bFieldInZ = 2 * u.T
deltaRMin = 20 * u.mm
maxPtScattering = float("inf") * u.GeV
deltaZMax = float("inf") * u.mm
zBinEdges = [
-3000.0,
-2500.0,
Expand Down Expand Up @@ -378,6 +377,7 @@ def itkSeedingAlgConfig(inputSpacePointsType: InputSpacePointsType):
deltaRMax = 280 * u.mm
deltaRMaxTopSP = 280 * u.mm
deltaRMaxBottomSP = 120 * u.mm
deltaZMax = float("inf") * u.mm
interactionPointCut = True
arithmeticAverageCotTheta = False
impactMax = 2 * u.mm
Expand Down Expand Up @@ -441,6 +441,7 @@ def itkSeedingAlgConfig(inputSpacePointsType: InputSpacePointsType):
deltaRMax = 600 * u.mm
deltaRMaxTopSP = 300 * u.mm
deltaRMaxBottomSP = deltaRMaxTopSP
deltaZMax = 900 * u.mm
interactionPointCut = False
arithmeticAverageCotTheta = True
impactMax = 20 * u.mm
Expand Down

0 comments on commit d2882c8

Please sign in to comment.