Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Fix
BinningValue
conversions (#2333)
In the ATLAS debug build, we're getting failures in the ActsEventCnv test: ``` ActsTrackingGeometrySvc FATAL in sysInitialize(): standard std::exception is caught ActsTrackingGeometrySvc ERROR [json.exception.type_error.302] type must be number, but is string ServiceManager ERROR Unable to initialize service "ActsTrackingGeometrySvc" ``` This is because some compilation units in Plugins/Json try to convert a BinningValue without including the header UtilitiesJsonConverter.hpp which has the NLOHMANN_JSON_SERIALIZE_ENUM declaration for BinningValue. Thus, the conversion can work differently depending on the compilation unit, and the behavior can also depend on what gets inlined, so can differ between the optimized and debug build. fixes #2331 Co-authored-by: scott-snyder <21222380+scott-snyder@users.noreply.github.com>
- Loading branch information