Skip to content

Commit

Permalink
fix: Multistepper error condition (#1747)
Browse files Browse the repository at this point in the history
There was a wrong abort condition in the `EigenMultiStepperLoop`'s step function, I think a leftover from a previous refactoring. This could lead to rare cases of not aborting the propagation, if all components have a stepping failure.
The new condition should fix this.
  • Loading branch information
benjaminhuth committed Dec 14, 2022
1 parent 7f4de98 commit e73b9a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Core/include/Acts/Propagator/MultiEigenStepperLoop.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ Result<double> MultiEigenStepperLoop<E, R, A>::step(
}

// Return error if there is no ok result
if (errorSteps == results.size()) {
if (stepping.components.empty()) {
return MultiStepperError::AllComponentsSteppingError;
}

Expand Down

0 comments on commit e73b9a6

Please sign in to comment.