Skip to content

Commit

Permalink
fix: Delete assignment operator for internal SPs (#1160)
Browse files Browse the repository at this point in the history
The internal spacepoint class promises that it has an assignment operator, but this is never implemented. This means that if you are to write some code that would invoke the assignment operator, you'll run into esoteric linker errors. We cannot usefully implement an assignment operator for this class, because it has a reference member. As such, we simply delete this operator.
  • Loading branch information
stephenswat committed Feb 14, 2022
1 parent c305fc4 commit eb51e5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Core/include/Acts/Seeding/InternalSpacePoint.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class InternalSpacePoint {
~InternalSpacePoint() = default;

InternalSpacePoint<SpacePoint>& operator=(
const InternalSpacePoint<SpacePoint>&);
const InternalSpacePoint<SpacePoint>&) = delete;

const float& x() const { return m_x; }
const float& y() const { return m_y; }
Expand Down

0 comments on commit eb51e5b

Please sign in to comment.