feat: deltaZ cut in SeedFinderOrthogonal (#1601)

same cut included in default seeding #1209
acts-project · Oct 18, 2022 · eef2627 · eef2627
1 parent 5592ff2
commit eef2627
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/Core/include/Acts/Seeding/SeedFinderOrthogonal.ipp b/Core/include/Acts/Seeding/SeedFinderOrthogonal.ipp
@@ -158,7 +158,8 @@ bool SeedFinderOrthogonal<external_spacepoint_t>::validTuple(
    * Cut: Ensure that the forward angle (z / r) lies within reasonable bounds,
    * which is to say the absolute value must be smaller than the max cot(θ).
    */
-  float cotTheta = (zH - zL) / deltaR;
+  float deltaZ = (zH - zL);
+  float cotTheta = deltaZ / deltaR;
   if (std::fabs(cotTheta) > m_config.cotThetaMax) {
     return false;
   }
@@ -172,6 +173,9 @@ bool SeedFinderOrthogonal<external_spacepoint_t>::validTuple(
       zOrigin > m_config.collisionRegionMax) {
     return false;
   }
+  if (std::abs(deltaZ) > m_config.deltaZMax) {
+    return false;
+  }
 
   return true;
 }

diff --git a/Core/include/Acts/Seeding/SeedFinderOrthogonalConfig.hpp b/Core/include/Acts/Seeding/SeedFinderOrthogonalConfig.hpp
@@ -74,6 +74,10 @@ struct SeedFinderOrthogonalConfig {
   Acts::Vector2 beamPos{0 * Acts::UnitConstants::mm,
                         0 * Acts::UnitConstants::mm};
 
+  // cut to the maximum value of delta z between SPs
+  float deltaZMax =
+      std::numeric_limits<float>::infinity() * Acts::UnitConstants::mm;
+
   // average radiation lengths of material on the length of a seed. used for
   // scattering.
   // default is 5%

diff --git a/Examples/Python/src/TrackFinding.cpp b/Examples/Python/src/TrackFinding.cpp
@@ -161,6 +161,7 @@ void addTrackFinding(Context& ctx) {
     ACTS_PYTHON_MEMBER(deltaRMinTopSP);
     ACTS_PYTHON_MEMBER(deltaRMaxTopSP);
     ACTS_PYTHON_MEMBER(impactMax);
+    ACTS_PYTHON_MEMBER(deltaZMax);
     ACTS_PYTHON_MEMBER(sigmaScattering);
     ACTS_PYTHON_MEMBER(maxPtScattering);
     ACTS_PYTHON_MEMBER(maxSeedsPerSpM);