feat: Add variable axis type for SpacePointGrid - Follow-up #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other to check if the variable binning significantly slows down the execution, I generated 1000 ttbar events using pythia8 and FatrasTGeo using the ATLAS response and ran the seeding example 10 times for the equidistant and variable binning with the same 100x100 grid. The average time spent per event using the equidistant binning was 0.045295s and using the variable binning was 0.045979s. The same results were achieved in almost the same time and we believe that it may not be worth adding more complications.
…ho/acts into variable-axistype
Codecov Report
@@ Coverage Diff @@
## main #1005 +/- ##
=======================================
Coverage 48.60% 48.60%
=======================================
Files 337 337
Lines 17330 17329 -1
Branches 8191 8191
=======================================
Hits 8423 8423
+ Misses 3166 3165 -1
Partials 5741 5741
Continue to review full report at Codecov.
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
This PR adds the `ITkSeedingExample.cpp` to run the ITk seeding. It shows how to configure the non-equidistant binning in z (#1005), the seed confirmation cuts (#1084), the radial range for middle SP cut (#1084) and the vector containing the map of z neighbours (#1052 and #1038). It contains all the parameters to run the seeding for ITk **pixel** space points (I intend to extend this to ITk strip SPs soon). @noemina @paulgessinger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I lost access to the PR #976 so I am creating this follow-up PR in order to fix some minor comments.